Next Maintainathon: Friday, January 18th!

[RichardLitt]

Let's have another one! Does this date work for you, @paulmelnikow and @jlilja? Gregor and I should be free for most of it (just talked to him). Anyone else want to join us, too, for a fun day of pair programming and collaborative hacking on Nock?

I think the goal for next week ought to be getting our coverage metrics a bit higher.

---

Update

Gitter chat: https://gitter.im/nock/Lobby
Zoom call: https://zoom.us/j/714137753

Today’s instructions

1. search the code base for "TODO-coverage":
   https://github.com/nock/nock/search?q=todo-coverage&unscoped_q=todo-coverage and just
2. Pick which of the comments you’d like to work on
3. Let us know which one you work on :)

[paulmelnikow]

That day should work for me!

I've been working on the coverage metric and I think more hands on that would be great. Though even more important to me is setting a goalpost together. We're in this phase where we're focused on improving the coverage before starting on bigger refactors, and it would be nice to have clarity on what work needs to be done to get there. I suggested a line-by-line triage: #1285 (comment)

[gr2m]

For the line-by-line triage we’d all need to be on a call, right? I think that might be hard. But maybe we can do that before hand with a few people with the goal to create separate issues (or a meta issues such as #1077) that we can then work off independently during the hackathon?

[paulmelnikow]

If we can swing that it sounds even better!

[gr2m]

I’ve some time this weekend. Maybe Saturday 10am Pacific time?

[RichardLitt]

I'll be AFK then; perhaps a time early next week?

[jlilja]

I've actually got another hackathon planned for that entire weekend. But I've planned to do some work this weekend on Nock, in case anyone wants to have a zoom chat. 😃

[RichardLitt]

Hmm. Perhaps Saturday at 10am PST would work for you? I can see if I can phone in.

[jlilja]

Sounds good to me! That'd be 19:00 CET for me, if I've got it right this time 😄

[paulmelnikow]

Great! It's on my calendar :)

[RichardLitt]

I've scheduled a Zoom meeting for ya'll. Details:

Join Zoom Meeting https://zoom.us/j/468734613
One tap mobile +19294362866,,468734613# US +16699006833,,468734613# US (San Jose) Dial by your location +1 929 436 2866 US +1 669 900 6833 US (San Jose) Meeting ID: 468 734 613 Find your local number: https://zoom.us/u/aMUEFGB9G

[paulmelnikow]

Hi! I'm standing by on this call :)

[gr2m]

I’ll be there in a minute

[gr2m]

@paulmelnikow @jlilja we had to move a doctor’s appointment and I think I won’t be able to make our call on Wednesday at 10.30 Pacific Time. Can we push it back (the later the more likely I’ll be able to make it) or do it at 7am Pacific time?

[paulmelnikow]

7–8:30 UTC-8 works for me.

Later also works, though it'll be evening @jlilja's time.

[RichardLitt]

I posted a Medium post about last time, and this Friday. :)

https://medium.com/nodenock/the-nock-maintainathon-success-f0f5ae07457a

[gr2m]

Sorry I just saw we were meant to start 7am! I’ve put it in my calendar for 7.30 🤦‍♂️ are you around @paulmelnikow @jlilja?

[paulmelnikow]

Joining now!

[paulmelnikow]

We decided to regroup in a few hours at 2:30 ET / 11:30 PT. I know that's pretty late for you @jlilja! If you or @RichardLitt are free to join us then, please do!

[jlilja]

So many time zones, hah. I haven't even gone for the day at my workplace yet. :)

That'd be 20:30 for me if I've counted right - works for me.

[paulmelnikow]

Hey @RichardLitt there was a comment in gitter by someone who landed on a locked post via medium. Could you link the old article to the new article? Since folks can’t post announcements maybe the CTA should also invite them to this thread.

[RichardLitt]

Ok. I'll update the CTA. I also posted the article in that issue. :)

[ehabdevel]

Hi,
Thank you for the opening invitation, you all do a great work.
and I think this day will be more helpful for me.
hope I can be a good support.

[gr2m]

I'll be on-and-off on Friday. Unfortunately we won’t have help with the kids and we have a doctors appointment at noon so I’m more restricted than I hoped. I’ll be around

• 9.00 - 10.30am
• 2.30 - 4.00pm

All in pacific time

[paulmelnikow]

I'm gonna aim for around 12-4 UTC-5 on Friday (which is 9-1 Pacific).

[RichardLitt]

I'm scheduled to be on for the same time! See you soon. :)

[ehabdevel]

( UTC-5 | pacific time | ET/PT | UTC-8 | CET | PST ) ... o.O

We still miss the GMT here,
I think the Maintainathon will start at 7:00 PM by my local Cairo time (GMT+2)

Hope somebody can find me online if I'm lost 😆

[RichardLitt]

Heh! We wanted to make it work for any time zone, so that people don't feel the need to be on at weird hours; hence setting it for 12-4, local time. It does mean you're likely to be alone, though. :/ Might be worth reconsidering this.

I'll be on from 12-4:00 EST today.

[gr2m]

Gitter chat: https://gitter.im/nock/Lobby
Zoom call: https://zoom.us/j/714137753

Today’s instructions

1. search the code base for "TODO-coverage":
   https://github.com/nock/nock/search?q=todo-coverage&unscoped_q=todo-coverage and just
2. Pick which of the comments you’d like to work on
3. Let us know which one you work on :)

[gr2m]

I’ll work on this one the one in socket.js

nock/lib/socket.js

Lines 46 to 56 in 950a7db

	if (this.timeoutMs && this.totalDelayMs > this.timeoutMs) {
	debug('socket timeout')
	// TODO-coverage: Rewrite this so it always emits. In `setTimeout()`, if a
	// timeout function is passed, register it using `this.once('timeout')`.
	if (this.timeoutFunction) {
	this.timeoutFunction()
	} else {
	this.emit('timeout')
	}
	}
	}

[RichardLitt]

Nice. I got the one in libRecorder.

[RichardLitt]

What branch do I submit a PR to?

[paulmelnikow]

What branch do I submit a PR to?

beta :)

[paulmelnikow]

I'm going to work on the coverage TODOs in request_overrider.js.

[paulmelnikow]

Should we open a new issue for the remaining TODO-coverage? I don't want this to get boring, though feel like we're going to need to tackle a few more of those before we can declare success.

Our coverage metric keeps creeping up, which is nice to see!

[gr2m]

good idea! Let's do a follow up issue for further discussion and then close this issue

[paulmelnikow]

Continuation in #1404.