-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add conditionally()
#1488
Conversation
…same host if one decides to filter out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for this.
I think this feature makes sense to include.
Though filter is a nice name for this function, it's already being used for filteringScope
and filteringRequestBody
, and this is doing something pretty different. What do you think about calling it conditionally()
instead?
Could you add an entry to the readme documenting the new API?
Hi @parisholley it would be great to get this merged! Would you have time to address any of the open items? |
@paulmelnikow done |
conditionally()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!! 🙌
🎉 This PR is included in version 11.0.0-beta.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I am building a test framework which depends on nock and to support concurrency, I need to be able shutoff certain scopes (to prevent cross-pollination) when running tests concurrently