You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This option seems to have been added to better support how the
recorder saves and plays back. But as it is a valid, public option it
should be documented.](86c5c4f) by mastermatt
🛠️ refactor(restoreOverriddenRequests): Eliminate uncovered line by paulmelnikow
🛠️ [refactor(scope): Replace unreachable conditional with an assertion (#1531) Several hours have been spent on this puzzling bit of uncovered code. I can’t remember what the last investigation revealed. It did not quite reach a conclusion nor can I find any notes about it.
Here's the Weekly Digest for nock/nock:
ISSUES
Last week 25 issues were created.
Of these, 23 issues have been closed and 2 issues are still open.
OPEN ISSUES
💚 #1520 Update/clarify interceptor.reply param juggling., by mastermatt
💚 #1516 11.x release plan, by paulmelnikow
CLOSED ISSUES
❤️ #1538 Update eslint-plugin-node to the latest version 🚀, by greenkeeper[bot]
❤️ #1537 chore(docs): Add encodedQueryParams option to docs., by mastermatt
❤️ #1536 The automated release is failing 🚨, by nockbot
❤️ #1535 test: Add test of DELETE request, by paulmelnikow
❤️ #1534 nock.delete doesn't match request (getting OPTIONS instead of DELETE), by Manny91
❤️ #1533 The automated release is failing 🚨, by nockbot
❤️ #1532 The automated release is failing 🚨, by nockbot
❤️ #1531 refactor(scope): Replace unreachable conditional with an assertion, by paulmelnikow
❤️ #1530 test(intercept): Reference the issue, by paulmelnikow
❤️ #1529 chore: Clean up some issue links, by paulmelnikow
❤️ #1528 chore(request_overrider): Update coverage TODOs, by paulmelnikow
❤️ #1527 refactor(restoreOverriddenRequests): Eliminate uncovered line, by paulmelnikow
❤️ #1526 fix(define): Throw error when legacy reply is in wrong format, by paulmelnikow
❤️ #1525 test(test_request_promise): Remove a library-specific test, by paulmelnikow
❤️ #1524 chore(tests): Disable got automatic retries which cause confusing behavior, by paulmelnikow
❤️ #1523 got() automatic retries makes for confusing failures in Nock tests, by paulmelnikow
❤️ #1522 refactor(tests): Rewrite some tests of delay and define using async/got, by paulmelnikow
❤️ #1521 Improve tests of .reply() with a synchronous function, by paulmelnikow
❤️ #1519 chore: Correct sorting of two tests, by paulmelnikow
❤️ #1518 chore: Organize the tests of .reply(), .replyWithFile(), and .replyWithError() to make them more digestible, by paulmelnikow
❤️ #1517 fix: Interceptor.reply to allow callback and raw headers., by mastermatt
❤️ #1515 Cannot respond with a 500 status, using got as client, by jsumners
❤️ #1514 Typescript definitions missing - encodedQueryParams and activeMocks, by tagyoureit
LIKED ISSUE
👍 #1523 got() automatic retries makes for confusing failures in Nock tests, by paulmelnikow
It received 👍 x1, 😄 x0, 🎉 x0 and ❤️ x0.
NOISY ISSUE
🔈 #1514 Typescript definitions missing - encodedQueryParams and activeMocks, by tagyoureit
It received 5 comments.
PULL REQUESTS
Last week, 16 pull requests were created, updated or merged.
UPDATED PULL REQUEST
Last week, 1 pull request was updated.
💛 #1520 Update/clarify interceptor.reply param juggling., by mastermatt
MERGED PULL REQUEST
Last week, 15 pull requests were merged.
💜 #1538 Update eslint-plugin-node to the latest version 🚀, by greenkeeper[bot]
💜 #1537 chore(docs): Add encodedQueryParams option to docs., by mastermatt
💜 #1535 test: Add test of DELETE request, by paulmelnikow
💜 #1531 refactor(scope): Replace unreachable conditional with an assertion, by paulmelnikow
💜 #1530 test(intercept): Reference the issue, by paulmelnikow
💜 #1529 chore: Clean up some issue links, by paulmelnikow
💜 #1528 chore(request_overrider): Update coverage TODOs, by paulmelnikow
💜 #1527 refactor(restoreOverriddenRequests): Eliminate uncovered line, by paulmelnikow
💜 #1526 fix(define): Throw error when legacy reply is in wrong format, by paulmelnikow
💜 #1525 test(test_request_promise): Remove a library-specific test, by paulmelnikow
💜 #1524 chore(tests): Disable got automatic retries which cause confusing behavior, by paulmelnikow
💜 #1522 refactor(tests): Rewrite some tests of delay and define using async/got, by paulmelnikow
💜 #1521 Improve tests of .reply() with a synchronous function, by paulmelnikow
💜 #1519 chore: Correct sorting of two tests, by paulmelnikow
💜 #1518 chore: Organize the tests of .reply(), .replyWithFile(), and .replyWithError() to make them more digestible, by paulmelnikow
COMMITS
Last week there were 17 commits.
🛠️ [Improve tests of .reply() with a synchronous function (#1521) - Add several tests for several missing edge cases.
🛠️ chore(package): update lockfile package-lock.json by greenkeeper[bot]
🛠️ chore(package): update eslint-plugin-node to version 9.0.0 by greenkeeper[bot]
🛠️ [docs(README): Add encodedQueryParams option to docs. (chore(docs): Add encodedQueryParams option to docs. #1537) Identified as missing here https://github.com/Typescript definitions missing - encodedQueryParams and activeMocks #1514#issuecomment-488742980.
This option seems to have been added to better support how the
recorder saves and plays back. But as it is a valid, public option it
should be documented.](86c5c4f) by mastermatt
🛠️ refactor(restoreOverriddenRequests): Eliminate uncovered line by paulmelnikow
🛠️ [refactor(scope): Replace unreachable conditional with an assertion (#1531) Several hours have been spent on this puzzling bit of uncovered code. I can’t remember what the last investigation revealed. It did not quite reach a conclusion nor can I find any notes about it.
I think this particular case is not worth investigating any further. Let’s keep the check (at least as long as this code is sitting around), and throw an error if it fails. We’ll find out soon enough if there is a use case where a non-string argument can reach this function.](fb21929) by paulmelnikow
🛠️ test: Add test of DELETE request Ref #1534 by paulmelnikow
🛠️ Move one more test by paulmelnikow
🛠️ chore: Correct sorting of one test by paulmelnikow
🛠️ refactor(tests): Rewrite some tests of delay and define using async/got (#1522) by paulmelnikow
🛠️ test(intercept): Reference the issue by paulmelnikow
🛠️ chore: Clean up some issue links by paulmelnikow
🛠️ chore(request_overrider): Update coverage TODOs I worked on this file quite a bit since this comment was written. At this point the remaining work can be broken out into separate, manageable-seeming todos. Ref #1404 by paulmelnikow
🛠️ fix(define): Throw error when legacy reply is in wrong format Shockingly,
_.isNumber(NaN)istruewhich means this conditional check didn’t even work as intended. Testing error paths is important! by paulmelnikow🛠️ test(test_request_promise): Remove a library-specific test This use cases seems to be covered by tests in
test_ipv6.js. Goes along with our decision in #1427 and prior, of handling nock-client integration tests in separate repos. by paulmelnikow🛠️ chore(tests): Disable got automatic retries which cause confusing behavior Fix #1523 by paulmelnikow
🛠️ refactor: organize the tests of .reply(), .replyWithFile(), and .replyWithError() to make them more digestible (#1518) by paulmelnikow
CONTRIBUTORS
Last week there were 3 contributors.
👤 paulmelnikow
👤 greenkeeper[bot]
👤 mastermatt
STARGAZERS
Last week there were 26 stagazers.
⭐ noluan
⭐ zidom
⭐ coder-layne
⭐ K3UL
⭐ tym1193
⭐ twooton61
⭐ ainestal
⭐ danielsbird
⭐ bj97301
⭐ LuisEGR
⭐ kenng
⭐ rogvold
⭐ diazig
⭐ dulewa
⭐ yasinuslu
⭐ ASSYANA
⭐ halitogunc
⭐ nfwyst
⭐ zaqqaz
⭐ KemalEmirhan
⭐ paganwinter
⭐ umutcanbolat
⭐ kucukkanat
⭐ fssantos
⭐ 7772
⭐ mlcdf
You all are the stars! 🌟
RELEASES
Last week there was 1 release.
🚀 v11.0.0-beta.11@beta v11.0.0-beta.11@beta
That's all for last week, please 👀 Watch and ⭐ Star the repository nock/nock to receive next weekly updates. 😃
You can also view all Weekly Digests by clicking here.
The text was updated successfully, but these errors were encountered: