Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Digest (18 August, 2019 - 25 August, 2019) #1697

Closed
weekly-digest bot opened this issue Aug 25, 2019 · 0 comments
Closed

Weekly Digest (18 August, 2019 - 25 August, 2019) #1697

weekly-digest bot opened this issue Aug 25, 2019 · 0 comments

Comments

@weekly-digest
Copy link

weekly-digest bot commented Aug 25, 2019

Here's the Weekly Digest for nock/nock:


ISSUES

Last week 16 issues were created.
Of these, 15 issues have been closed and 1 issues are still open.

OPEN ISSUES

💚 #1692 fix: Throw errors when base URLs are specified incorrectly, by paulmelnikow

CLOSED ISSUES

❤️ #1696 The automated release is failing 🚨, by nockbot
❤️ #1695 fix(types): use export = and declares, by mastermatt
❤️ #1694 published TypeScript definitions incompatible with @types/nock, by bcoe
❤️ #1693 style: Minor style improvements, by paulmelnikow
❤️ #1691 refactor: Remove the last of the real hostnames, by paulmelnikow
❤️ #1690 test: Replace test_s3 with test of Expect: 100-continue, by paulmelnikow
❤️ #1689 refactor: Update hostname in goodRequest.json, by paulmelnikow
❤️ #1688 refactor: Refactor net connect tests, by paulmelnikow
❤️ #1687 docs: Add "Common issues" section documenting got automatic retrying, by paulmelnikow
❤️ #1686 An in-range update of aws-sdk is breaking the build 🚨, by greenkeeper[bot]
❤️ #1685 refactor: replace some lodash usage with native, by mastermatt
❤️ #1684 [question] Exported Typescript types in Upper Case intended?, by Retro64
❤️ #1683 chore: add extension to main field in package.json, by mastermatt
❤️ #1682 feat: afterRecord support for custom formatting after recording., by krackerman
❤️ #1681 Update eslint-config-standard to the latest version 🚀, by greenkeeper[bot]

LIKED ISSUE

👍 #1682 feat: afterRecord support for custom formatting after recording., by krackerman
It received 👍 x0, 😄 x0, 🎉 x0 and ❤️ x2.

NOISY ISSUE

🔈 #1694 published TypeScript definitions incompatible with @types/nock, by bcoe
It received 5 comments.


PULL REQUESTS

Last week, 19 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 5 pull requests were updated.
💛 #1692 fix: Throw errors when base URLs are specified incorrectly, by paulmelnikow
💛 #1678 refactor: Refactor recorder stringification, by paulmelnikow
💛 #1677 refactor: Separate concerns of interceptor brokering and playback (+ other minor refactors), by paulmelnikow
💛 #1673 refactor: Refactor exports to reduce indirection, by paulmelnikow
💛 #1671 11.x release notes, by paulmelnikow

MERGED PULL REQUEST

Last week, 14 pull requests were merged.
💜 #1695 fix(types): use export = and declares, by mastermatt
💜 #1693 style: Minor style improvements, by paulmelnikow
💜 #1691 refactor: Remove the last of the real hostnames, by paulmelnikow
💜 #1690 test: Replace test_s3 with test of Expect: 100-continue, by paulmelnikow
💜 #1688 refactor: Refactor net connect tests, by paulmelnikow
💜 #1687 docs: Add "Common issues" section documenting got automatic retrying, by paulmelnikow
💜 #1685 refactor: replace some lodash usage with native, by mastermatt
💜 #1683 chore: add extension to main field in package.json, by mastermatt
💜 #1682 feat: afterRecord support for custom formatting after recording., by krackerman
💜 #1681 Update eslint-config-standard to the latest version 🚀, by greenkeeper[bot]
💜 #1679 refactor: Fix two tests that don't work on an airplane, by paulmelnikow
💜 #1676 feat(types): Add Typescript definitions., by mastermatt
💜 #1675 Feat: Added response.destroy method, by b4dnewz
💜 #1109 Add test case for conflict between hostnames (#1108), by coleturner


COMMITS

Last week there were 14 commits.
🛠️ refactor: Remove the last of the real hostnames (#1691) Closes #1351 by paulmelnikow
🛠️ [test: Replace test_s3 with test of Expect: 100-continue (#1690) This is a new regression test for #256, though the behavior has changed since the original implementation.

See discussion on testing strategy in #1288 and #1427.](76cc613) by paulmelnikow
🛠️ [fix(types): use export = and declares (#1695) * fix(types): use export = and declares

Fixes: #1694
From my testing, I haven't been able to find any negatives with using
export = and declare vs direct export when using TS 3+. Going
this route allows for consumers still using TS2 and/or not using
esModuleInterop to still utilize the bundled types.

Closes: #1684
I don't think the casing of the exported object makes a difference
either way, but using lowercase seems to fit with common usage (as a
function) better.](65a8a6a) by mastermatt
🛠️ refactor: Refactor net connect tests (#1688) Ref #1351 by paulmelnikow
🛠️ docs: Add "Common issues" section documenting got automatic retrying (#1687) Closes #1661 by paulmelnikow
🛠️ style: Minor style improvements (#1693) by paulmelnikow
🛠️ test: Add todo test for conflict between hostnames (#1109) Ref #1108 by coleturner
🛠️ [fix: add extension to main field in package.json (#1683) This doesn't add much value from Node's POV, since it can resolve it all
the same, however, some tools get confused.

index.js is also the default value for the field so it could be
removed, but it's probably for the best to be explicit.

Fixes: #1654](057bbdf) by mastermatt
🛠️ [refactor: replace some lodash usage with native (#1685) For: #1285

Not logic changes, just making use of newer JS.](89eb03a) by mastermatt
🛠️ [Update eslint-config-standard to the latest version 🚀 (#1681) * chore(package): update eslint-config-standard to version 14.0.0

#1599](e0930f8) by krackerman
🛠️ [feat(socket): propagate errors from destroy method (#1675) Calling destroy on the the response, with an error, not correctly propagates through the socket and then the request object. This aligns with Node's native functionality.

Fixes: #1669](de9c40b) by b4dnewz
🛠️ [feat(types): Add Typescript definitions. (#1676) Fixes: #1670

Copies over the existing types and tests from DefinitelyTyped.
Includes updates to bring them up to date with 11.0

Remove getTotalDelay and shouldPersist, as they're considered private.](2e56fb0) by mastermatt
🛠️ refactor: Fix two tests that don’t work on an airplane (#1679) by paulmelnikow


CONTRIBUTORS

Last week there were 6 contributors.
👤 paulmelnikow
👤 mastermatt
👤 coleturner
👤 greenkeeper[bot]
👤 krackerman
👤 b4dnewz


STARGAZERS

Last week there were 40 stagazers.
tensor1014
jie17
niktekusho
adambalogh
iamuchejude
flo-baheux
Moskovskiy
antkaynak
SamoilovKonstantin
leonardosal
brookemitchell
miguelramos
fhpriamo
chi11ed
Cyrus-d
enzoborgfrantz
OussamaRomdhane
cn894
alperunal
Drbeo
PMudra
Sphiinx
tsub
CarlyAdam
Jhamm1
mkinit
ashishtanwer
myreli
tony3918
fmt
atliuhui
dgorst
danilomacb
filipelinhares
tpamula
JavierCane
gvvynplaine
prattheev
albburtsev
Zaseth
You all are the stars! 🌟


RELEASES

Last week there were 5 releases.
🚀 v11.3.2@next v11.3.2@next
🚀 v11.3.1@next v11.3.1@next
🚀 v11.3.0@next v11.3.0@next
🚀 v11.2.0@next v11.2.0@next
🚀 v11.1.0@next v11.1.0@next


That's all for last week, please 👀 Watch and Star the repository nock/nock to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant