Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): DataMatcher to allow valid JSON scalars. #1703

Merged
merged 1 commit into from Sep 4, 2019
Merged

fix(types): DataMatcher to allow valid JSON scalars. #1703

merged 1 commit into from Sep 4, 2019

Conversation

mastermatt
Copy link
Member

Fixes: #1702

@mastermatt mastermatt added bug TypeScript Anything related to TypeScript labels Sep 4, 2019
@paulmelnikow paulmelnikow changed the title fix(type): DataMatcher to allow valid JSON scalars. fix(types): DataMatcher to allow valid JSON scalars. Sep 4, 2019
@mastermatt mastermatt merged commit a700fa2 into nock:master Sep 4, 2019
@mastermatt mastermatt deleted the types/datamatcher-more-jsony branch September 4, 2019 20:35
@nockbot nockbot mentioned this pull request Sep 4, 2019
Closed
@nockbot
Copy link
Collaborator

nockbot commented Sep 5, 2019

🎉 This PR is included in version 11.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@paulmelnikow paulmelnikow mentioned this pull request Sep 6, 2019
Closed
@mastermatt mastermatt mentioned this pull request Sep 8, 2019
Closed
@mastermatt mastermatt mentioned this pull request Sep 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

Assignees
No one assigned
Labels
bug released TypeScript Anything related to TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid typings of request matchers
3 participants
@mastermatt @nockbot @paulmelnikow