empty string vs "/"

[pociej]

I wouldn't say its bug but maybe its a bit strange behaviour.
Compare two cases

it("should just pass", done => {
  nock("http://test.com")
    .post("")
    .reply(200, function(url, data) {
      return {};
    });
  got.post("http://test.com", {});
  done();
});

it("should just pass", done => {
 nock("http://test.com")
   .post("/")
   .reply(200, function(url, data) {
     return {};
   });
 got.post("http://test.com", {});
 done();
});

The first one fails because got( https://www.npmjs.com/package/got) makes request to http://test.com/ while nock is watching connections to http://test.com. But shouldn't those be equal from nock perspective?

[paulmelnikow]

Hi! Yea, you're right, the second one is "correct" but it's strange that the first one basically does nothing. There are a few cases like filteringScope() where the path passed to e.g. .post() is ignored, though in any other case it needs to be a string that starts with a /.

It's not very helpful to silently ignore bad input. Would be great to improve our error messages around this (while being thoughtful about backward compatibility for legitimate use cases. Would you be interested in working on that? If not, no worries, we can leave this open.

[nockbot]

🎉 This issue has been resolved in version 11.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀