Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type for Nock Back currentMode #1794

Merged
merged 2 commits into from Oct 31, 2019
Merged

Conversation

tteltrab
Copy link
Contributor

currentMode exists but isn't typed - https://github.com/nock/nock/blob/master/lib/back.js#L282

It's referenced in the docs here https://github.com/nock/nock#modes

Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick!

@paulmelnikow paulmelnikow added the TypeScript Anything related to TypeScript label Oct 30, 2019
@paulmelnikow paulmelnikow changed the title add type for currentMode feat: add type for Nock Back currentMode Oct 31, 2019
@paulmelnikow paulmelnikow merged commit ba60fd2 into nock:master Oct 31, 2019
@nockbot
Copy link
Collaborator

nockbot commented Oct 31, 2019

🎉 This PR is included in version 11.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tteltrab tteltrab deleted the patch-1 branch November 4, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released TypeScript Anything related to TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants