Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use typeof instead of instanceof #1850

Merged
merged 2 commits into from Jan 8, 2020
Merged

fix: use typeof instead of instanceof #1850

merged 2 commits into from Jan 8, 2020

Conversation

salmanm
Copy link
Contributor

@salmanm salmanm commented Jan 7, 2020

@salmanm salmanm mentioned this pull request Jan 7, 2020
Merged
@offirgolan offirgolan mentioned this pull request Jan 8, 2020
Closed
@offirgolan
Copy link

👋 this is a blocking issue for us as Nock isn't handling stream responses correctly as the common.isStream util always returns false. Would love to get this in and released asap 😅

paulmelnikow
paulmelnikow reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link to the place where this was discussed.

@salmanm @paulmelnikow
Update lib/intercepted_request_router.js
922eb11 
Co-Authored-By: Paul Melnikow <github@paulmelnikow.com>
@salmanm
Copy link
Contributor Author

salmanm commented Jan 8, 2020

Thanks @paulmelnikow, lets ship it.

@paulmelnikow paulmelnikow merged commit c7363e5 into nock:master Jan 8, 2020
@paulmelnikow
Copy link
Member

Thanks for the report and the fix!

@nockbot
Copy link
Collaborator

nockbot commented Jan 8, 2020

🎉 This PR is included in version 11.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

kennethaasan pushed a commit to kennethaasan/nock that referenced this pull request Jan 10, 2020
@salmanm @kennethaasan
fix: Fix a regression due to Jest having different globals (nock#1850)
52159c9 
Fix a regression in 11.7.1 due to Jest having different globals: jestjs/jest#2549. Check functions using typeof instead of instanceof.
nikaspran added a commit to nikaspran/nock that referenced this pull request Feb 10, 2020
@nikaspran
Use typeof instead of instanceof (PR nock#1850)
51810a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow left review comments

@mastermatt mastermatt mastermatt approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@salmanm @offirgolan @paulmelnikow @nockbot @mastermatt