Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return the nock global from cleanAll() #1872

Merged
merged 3 commits into from Feb 11, 2020
Merged

Conversation

paulmelnikow
Copy link
Member

BREAKING CHANGE

This should not be merged to master. See #1871.

@paulmelnikow paulmelnikow marked this pull request as ready for review February 11, 2020 03:17
@paulmelnikow paulmelnikow merged commit e276741 into beta Feb 11, 2020
@paulmelnikow paulmelnikow deleted the clean-all-ret branch February 11, 2020 03:36
@github-actions
Copy link

🎉 This PR is included in version 11.9.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mastermatt pushed a commit to mastermatt/nock that referenced this pull request Feb 12, 2020
paulmelnikow added a commit that referenced this pull request Feb 13, 2020
gr2m pushed a commit that referenced this pull request Feb 16, 2020
BREAKING CHANGE: Do not return the `nock` global from `cleanAll()` (#1872)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
BREAKING CHANGE: Do not return the `nock` global from `cleanAll()` (#1872)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
BREAKING CHANGE: Do not return the `nock` global from `cleanAll()` (#1872)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
BREAKING CHANGE: Do not return the `nock` global from `cleanAll()` (#1872)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
BREAKING CHANGE: Do not return the `nock` global from `cleanAll()` (#1872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants