Drop support for String constructor #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.
mastermatt
approved these changes
Feb 11, 2020
|
🎉 This PR is included in version 11.9.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mastermatt
pushed a commit
to mastermatt/nock
that referenced
this pull request
Feb 12, 2020
BREAKING CHANGE When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.
paulmelnikow
added a commit
that referenced
this pull request
Feb 13, 2020
BREAKING CHANGE When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.
gr2m
pushed a commit
that referenced
this pull request
Feb 16, 2020
BREAKING CHANGE: Drop support for String constructor (#1873) When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.
gr2m
pushed a commit
that referenced
this pull request
Feb 16, 2020
BREAKING CHANGE: Drop support for String constructor (#1873) When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.
gr2m
pushed a commit
that referenced
this pull request
Feb 16, 2020
BREAKING CHANGE: Drop support for String constructor (#1873) When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.
gr2m
pushed a commit
that referenced
this pull request
Feb 16, 2020
BREAKING CHANGE: Drop support for String constructor (#1873) When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.
gr2m
pushed a commit
that referenced
this pull request
Feb 16, 2020
BREAKING CHANGE: Drop support for String constructor (#1873) When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.