Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node 10+ #1895

Merged
merged 4 commits into from Feb 11, 2020
Merged

Require Node 10+ #1895

merged 4 commits into from Feb 11, 2020

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Feb 11, 2020

BREAKING CHANGE

Close #1871

BREAKING CHANGE
@paulmelnikow
Copy link
Member Author

This won't turn green because Node 8 is still required on the repo. I think we probably can turn it off for the repo once this is merged, though if we want to leave it turned on, I guess we need to leave an empty Node 8 job in this branch.

package.json Outdated
@@ -17,7 +17,7 @@
"url": "http://github.com/nock/nock/issues"
},
"engines": {
"node": ">= 8.0"
"node": ">= 10.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the idea is to only support LTS, this should be >=10.13.
https://nodejs.org/en/download/releases/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think LTS and Active.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be supporting LTS Active and Maintenance.
https://nodejs.org/en/about/releases/
Otherwise we'd be dropping 10.x in two months.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ones we support on that chart are Current, Active, and Maintenance. Does that sound right?

@paulmelnikow
Copy link
Member Author

This won't turn green because Node 8 is still required on the repo. I think we probably can turn it off for the repo once this is merged, though if we want to leave it turned on, I guess we need to leave an empty Node 8 job in this branch.

Ah, I can turn it off for the beta branch.

@gr2m
Copy link
Member

gr2m commented Feb 11, 2020

BREAKING CHANGE is not enough, you need to add a :. I know, tricky one, this happened to me before. But that's the reason why no new release was created for after this merge https://github.com/nock/nock/runs/437745060?check_suite_focus=true#step:5:65

@github-actions
Copy link

🎉 This PR is included in version 11.9.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mastermatt pushed a commit to mastermatt/nock that referenced this pull request Feb 12, 2020
paulmelnikow added a commit that referenced this pull request Feb 13, 2020
BREAKING CHANGE
gr2m pushed a commit that referenced this pull request Feb 16, 2020
BREAKING CHANGE: Require Node 10+ (#1895)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
BREAKING CHANGE: Require Node 10+ (#1895)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
BREAKING CHANGE: Require Node 10+ (#1895)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
BREAKING CHANGE: Require Node 10+ (#1895)
gr2m pushed a commit that referenced this pull request Feb 16, 2020
BREAKING CHANGE: Require Node 10+ (#1895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants