New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Node 10+ #1895
Require Node 10+ #1895
Conversation
BREAKING CHANGE
This won't turn green because Node 8 is still required on the repo. I think we probably can turn it off for the repo once this is merged, though if we want to leave it turned on, I guess we need to leave an empty Node 8 job in this branch. |
package.json
Outdated
@@ -17,7 +17,7 @@ | |||
"url": "http://github.com/nock/nock/issues" | |||
}, | |||
"engines": { | |||
"node": ">= 8.0" | |||
"node": ">= 10.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the idea is to only support LTS, this should be >=10.13
.
https://nodejs.org/en/download/releases/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think LTS and Active.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be supporting LTS Active and Maintenance.
https://nodejs.org/en/about/releases/
Otherwise we'd be dropping 10.x in two months.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ones we support on that chart are Current, Active, and Maintenance. Does that sound right?
Ah, I can turn it off for the |
|
🎉 This PR is included in version 11.9.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE
BREAKING CHANGE: Require Node 10+ (#1895)
BREAKING CHANGE: Require Node 10+ (#1895)
BREAKING CHANGE: Require Node 10+ (#1895)
BREAKING CHANGE: Require Node 10+ (#1895)
BREAKING CHANGE: Require Node 10+ (#1895)
BREAKING CHANGE
Close #1871