fix: Replace a few more uses of lodash #1916
Conversation
| this.options = { | ||
| ...this.scope.scopeOptions, | ||
| ...this.options, | ||
| } |
There was a problem hiding this comment.
Are these guaranteed to be shallow objects?
There was a problem hiding this comment.
I’m not sure, though I think this is the same behavior as _.defaults.
There was a problem hiding this comment.
yes, your change is parity.
But I'm questioning if that is correct. Some of the options are objects, eg reqheaders. So I think it's a bug that it doesn't do deep cloning.
There was a problem hiding this comment.
That's possible. I don't know what the use cases are for merging these options. I'm not sure if it's possible that reqheaders could end up in both (or if merging them would be the correct thing to do). Would you like me to add a todo comment?
There was a problem hiding this comment.
hmmm, yeah it's a weird undocumented case. I think I'd vote for keeping with your current change since it keeps parity and come back to it again if anyone ever opens an issue.
paulmelnikow
changed the title
|
🎉 This PR is included in version 12.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I marked this a fix because the |
Ref #1285