Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail in 13.10.x #1947

Closed
mastermatt opened this issue Mar 7, 2020 · 6 comments
Closed

Tests fail in 13.10.x #1947

mastermatt opened this issue Mar 7, 2020 · 6 comments

Comments

@mastermatt
Copy link
Member

Identified when #1945 and #1946 suspiciously didn't pass their CI checks.
I've confirmed locally, on MacOS 10.15.3, that 13.10.0 and 13.10.1 both fail. Most, but not all, tests just timeout.

I've just started investigating, I'll update as I find things.

@mastermatt
Copy link
Member Author

@mastermatt
Copy link
Member Author

It seems a bug in 13.10 broke Got.
sindresorhus/got#1107
nodejs/node#32105

It looks like PRs for Node are in play already and should land next week.
We can probably ride it out.

@mastermatt mastermatt changed the title Nock does not work with 13.10.x Tests fail in 13.10.x Mar 7, 2020
@gugu
Copy link
Contributor

gugu commented Mar 11, 2020

is it possible to add throwing errors for node v13.10.0-v13.10.2? (I can send PR if it is ok)

@mastermatt
Copy link
Member Author

v13 isn't a stable version, we only test on it to be ahead of the curve. Once the back port is released (already merged in) this should be a non-issue for the most part.

Or maybe my thought process is better stated by saying this isn't an issue with Nock, or even Got, it would feel like clutter or kludge pretty quick.

@gugu
Copy link
Contributor

gugu commented Mar 11, 2020

Got it

@mastermatt
Copy link
Member Author

13.11 was releases and tests are passing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants