New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail in 13.10.x #1947
Comments
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md#13.10.0 Both Tap and Mocha are affected. |
It seems a bug in 13.10 broke Got. It looks like PRs for Node are in play already and should land next week. |
is it possible to add throwing errors for node v13.10.0-v13.10.2? (I can send PR if it is ok) |
v13 isn't a stable version, we only test on it to be ahead of the curve. Once the back port is released (already merged in) this should be a non-issue for the most part. Or maybe my thought process is better stated by saying this isn't an issue with Nock, or even Got, it would feel like clutter or kludge pretty quick. |
Got it |
13.11 was releases and tests are passing now. |
Identified when #1945 and #1946 suspiciously didn't pass their CI checks.
I've confirmed locally, on MacOS 10.15.3, that 13.10.0 and 13.10.1 both fail. Most, but not all, tests just timeout.
I've just started investigating, I'll update as I find things.
The text was updated successfully, but these errors were encountered: