RegExp with global flag does not match the request path

[nivsherf]

What is the expected behavior?
When using a RegExp in the path, I expect nock to match regardless of if the RegExp has the global flag set.

const scope = nock('https://api.github.com')
    .get(/repos.*/g).reply(200, { foo: 'bar' })
const response = await request.get('https://api.github.com/repos/atom/atom/license');
console.log(scope.isDone()); // I expect this to equal true

What is the actual behavior?
A global RegExp does not match even when it should.

// without global flag - /repos.*/ - matches
let scope = nock('https://api.github.com')
    .get(/repos.*/).reply(200, { foo: 'bar' })
const response = await request.get('https://api.github.com/repos/atom/atom/license');
console.log(scope.isDone()); // true

// with global flag - /repos.*/g - doesn't match
scope = nock('https://api.github.com')
    .get(/repos.*/g).reply(200, { foo: 'bar' })
const response = await request.get('https://api.github.com/repos/atom/atom/license');
console.log(scope.isDone()); // false

Possible solution
Since I can see no reason why would someone need global matching here (though it was actually used in a codebase I'm working on, and broke after upgrading nock), and this is broken for quite some time (git bisect shows that the offending commit is c1f7082 from July 19), I suggest throwing an explicit error whenever someone tries to pass a RegExp with the global flag.
If you think that this is a reasonable solution, I will submit a PR.

How to reproduce the issue
Here is the script I used with git bisect

Does the bug have a test case?

Versions

Software	Version(s)
Nock	v13.0.5
Node	v14.15.3
TypeScript

[mastermatt]

Interesting find. Thanks @nivsherf.

The issue with global flags in this case is that they maintain state. MDN docs for RegExp.prototype.test()

As with exec() (or in combination with it), test() called multiple times on the same global regular expression instance will advance past the previous match.

Which leads to this fun bit of JS quirkiness:

const reg = /repos.*/g;
const str = '/repos/atom/atom/license';
console.log(reg.test(str), reg.test(str), reg.test(str), reg.test(str));
> true false true false

While it isn't sensical for the regexp instance to have a global flag in this use case, I do consider it a bug that Nock isn't consistent with its behavior. Throwing an error would be an option, but so would setting the lastIndex to zero before calling test. The latter would align with legacy behavior and seems like the better user experience to me. I'm curious if anyone would prefer the error.

I have a patch written already, PR inbound...

[github-actions]

🎉 This issue has been resolved in version 13.0.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀