-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nock.recorder.rec
does not record when stream not put into flowing mode
#2185
Comments
Hi! Just wagering a guess that this is not a problem with nock. I’d guess an invalid bucket and key is erroring out in the AWS SDK before the HTTP request is made. Maybe you can catch the exception and see. |
You can see the response is 200 when logged by |
@paulmelnikow thanks for your extremely fast response earlier. I have been looking into this some more and found that adding
I guess in this case the stream is never put into flowing mode, so unless the client actually consumes the stream |
nock.recorder.rec
does not record AWS S3 V3 GetObject when object existsnock.recorder.rec
does not record when stream not put into flowing mode
@att14 could you start a pull request with a test replicating the issue? That'd be a great start to address it |
…eam not put in flowing mode
Okay, #2257 has been created. |
…eam not put in flowing mode
What is the expected behavior?
nock.recorder.play()
should contain the recorded version of the request to GetObject.What is the actual behavior?
Request does not appear in array returned from
nock.recorder.play()
.How to reproduce the issue
Fill in
bucket
andkey
and run.key
must be a valid and present S3 key.With a valid
bucket
andkey
the output is:Versions
The text was updated successfully, but these errors were encountered: