fix: send Buffer with length

[Beretta1979]

#A buffer with length 0 should still be sent
See https://github.com/nodejs/node/blob/3f11666dc7e3a6d1221bde5145929dc72edc142e/lib/_http_outgoing.js#L788

fixes #2231

I wanted to target the 13.x branch, but that one was non existent ...

[Beretta1979]

The failing test (write callback is not called if the provided chunk is an empty buffer) could be fixed with changing:

const buf = Buffer.from('') req.write(null, null, reqWriteCallback)
to
req.write(null, null, reqWriteCallback)
If I look at the chainges which introduced this test it would make more sense (the description needs to change too)

[gr2m]

I wanted to target the 13.x branch, but that one was non existent ...

Everything merged into current main publishes to the current version, which is 13. We only have 12.x etc branches so we can backport fixes to previous versions

The failing test (write callback is not called if the provided chunk is an empty buffer) could be fixed with changing:

const buf = Buffer.from('') req.write(null, null, reqWriteCallback) to req.write(null, null, reqWriteCallback) If I look at the chainges which introduced this test it would make more sense (the description needs to change too)

can you push the change?

[Beretta1979]

I updated the unit test and also added the test which reproduces the issue

[gr2m]

@all-contributors please add @Beretta1979 for code and test

[allcontributors]

@gr2m

I've put up a pull request to add @Beretta1979! 🎉

[gr2m]

great PR, thank you 💐 I confirmed that the your test failed before adding the fix

[github-actions]

🎉 This PR is included in version 13.1.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[Beretta1979]

Thanks! And thumbs up for this nice easy to use package!