Push persisted interceptors to the end instead of ignore on remove

[mikicho]

Currently, if you do:

nock(..).get('/').reply(200).persist();
nock(..).get('/').reply(400); // this will never get called

The second interceptor won't get called ever.

But sometimes in tests (queue for examples), I want to do:

beforeAll(() => {
  // some default behaviour
  nock(..).get('/').reply(200).persist();
});
test('should ...', () => {
  // test specific scenario for this same endpoint above
  nock(..).get('/').reply(400)
})

I find a workaround using the body matcher function:

const createInterceptor = () => {
  nock(..).get('/', () => { 
    createInterceptor(); 
    return true; 
  })
  .reply(200)
}

Which pushes the interceptor to the end of the queue (interceptors array) and mimics the wanted behavior but is slower and way less elegant.

P.S: I'll add tests and documentation if we agree on the wanted behavior.

[mikicho]

Trying my luck.
@gr2m can you please take a look on this?

[gr2m]

Currently, if you do:

nock(..).get('/').reply(200).persist();
nock(..).get('/').reply(400); // this will never get called

The second interceptor won't get called ever.

Just to check, swapping the lines around works, but you can't do it because you call the .perst() line in a beforeEach block?

As long as no other tests break and you update docs, I'd be happy to help get it landed.

Sorry for the late response

[mikicho]

Just to check, swapping the lines around works, but you can't do it because you call the .perst() line in a beforeEach block?

beforeAll, yes.

As long as no other tests break and you update docs, I'd be happy to help get it landed.

Cool! I'll add relevant tests.

[mikicho]

@gr2m PTAL

[gr2m]

Thank you so much 💐

[github-actions]

🎉 This PR is included in version 13.3.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀