Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response headers missing on Node.js 19.1 #2414

Closed
1 of 2 tasks
kevinoid opened this issue Nov 15, 2022 · 3 comments
Closed
1 of 2 tasks

Response headers missing on Node.js 19.1 #2414

kevinoid opened this issue Nov 15, 2022 · 3 comments
Labels

Comments

@kevinoid
Copy link

Please avoid duplicates

Reproducible test case

https://runkit.com/kevinoid/nock-response-headers-missing-on-node-js-19-1

Nock Version

13.2.9

Node Version

19.1.0

TypeScript Version

No response

What happened?

When the linked example is run on Node.js 19.0.1 and earlier, it prints

Response headers: { 'x-ratelimit-remaining': '4999', 'content-type': 'application/json' }

When run on Node.js 19.1.0 it prints

Response headers: {}

which is missing the response headers given to nock.

Would you be interested in contributing a fix?

  • yes
@kevinoid kevinoid added the bug label Nov 15, 2022
kevinoid added a commit to kevinoid/swagger-spec-validator that referenced this issue Nov 17, 2022
Until nock/nock#2414 is fixed.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
@panva
Copy link

panva commented Nov 19, 2022

@panva
Copy link

panva commented Nov 20, 2022

The breaking change is being reverted for 19.x but will be re-landed as semver-major for 20.x

@mikicho
Copy link
Contributor

mikicho commented Feb 25, 2024

This is working with version 20:
image
And v19.9.0.

Feel free to reopen if needed.

@mikicho mikicho closed this as completed Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants