fix: update Socket for Node 18 compat #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Node 18+, Write Stream detection has changed. We needed to add a dummy `write` method to our `Socket` class in order to avoid the following error: > The "stream" argument must be an instance of ReadableStream, WritableStream, or Stream. Received an instance of Socket The minimum requirements for SSL certs also increased, so I was forced to update our certs used in testing.
mastermatt
force-pushed
the
node18-compat
branch
from
86e3e5b
to
5ecd4eb
Compare
|
@nock/maintainers could I get an approval on this? |
mastermatt
changed the title
RichardLitt
approved these changes
Apr 27, 2023
|
Approved. |
|
🎉 This PR is included in version 13.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node 18+, Write Stream detection has changed. We needed to add a dummy
writemethod to ourSocketclass in order to avoid the following error:The minimum requirements for SSL certs also increased, so I was forced to update our certs used in testing.
Fixes #2466