fix(memory): passing 0 to ttl argument does not work (#282)

jaredwray · Dec 1, 2022 · d6c2ed5 · d6c2ed5
1 parent 0bcb151
commit d6c2ed5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/stores/memory.ts b/src/stores/memory.ts
@@ -36,7 +36,7 @@ export function memoryStore(args?: MemoryConfig): MemoryStore {
   const lruOpts = {
     ...args,
     max: args?.max || 500,
-    ttl: args?.ttl ? args.ttl : 0,
+    ttl: args?.ttl !== undefined ? args.ttl : 0,
   };
 
   const lruCache = new LRUCache<string, unknown>(lruOpts);
@@ -49,7 +49,7 @@ export function memoryStore(args?: MemoryConfig): MemoryStore {
     keys: async () => [...lruCache.keys()],
     mget: async (...args) => args.map((x) => lruCache.get(x)),
     async mset(args, ttl?) {
-      const opt = { ttl: ttl ? ttl : lruOpts.ttl } as const;
+      const opt = { ttl: ttl !== undefined ? ttl : lruOpts.ttl } as const;
       for (const [key, value] of args) {
         if (!isCacheable(value))
           throw new Error(`no cacheable value ${JSON.stringify(value)}`);
@@ -69,7 +69,7 @@ export function memoryStore(args?: MemoryConfig): MemoryStore {
         throw new Error(`no cacheable value ${JSON.stringify(value)}`);
       if (shouldCloneBeforeSet) value = clone(value);
 
-      const ttl = opt ? opt : lruOpts.ttl;
+      const ttl = opt !== undefined ? opt : lruOpts.ttl;
 
       lruCache.set(key, value, { ttl });
     },

diff --git a/test/stores/memory.test.ts b/test/stores/memory.test.ts
@@ -24,6 +24,13 @@ describe('memory store', () => {
       await expect(store.get('foo')).resolves.toEqual('bar');
     });
 
+    it('when ttl arg is passed 0', async () => {
+      const store = memoryStore({ ttl: 1 });
+      await store.set('foo', 'bar', 0);
+      await sleep(20);
+      await expect(store.get('foo')).resolves.toEqual('bar');
+    });
+
     it('cache record should be expired', async () => {
       await store.set('foo', 'bar', 1);
       await sleep(20);