Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separete "accept-encoding" values with ", " #1571

Closed
AlttiRi opened this issue May 31, 2022 · 1 comment · Fixed by #1572
Closed

Separete "accept-encoding" values with ", " #1571

AlttiRi opened this issue May 31, 2022 · 1 comment · Fixed by #1572
Labels
bug good first issue help wanted released

Comments

@AlttiRi
Copy link

AlttiRi commented May 31, 2022

The minor issue from #1569.

Currently it by default sends "accept-encoding": "gzip,deflate,br".

I think it should send "accept-encoding": "gzip, deflate, br", header as browsers and other libraries do.

Separate "accept-encoding"'s values with ", " instead of just ",".

"node-fetch": "3.2.3"
@AlttiRi AlttiRi added the bug label May 31, 2022
tmclo added a commit to tmclo/node-fetch that referenced this issue May 31, 2022
@tmclo
fix for issue node-fetch#1571
40a1865
@tmclo tmclo mentioned this issue May 31, 2022
Merged
jimmywarting added a commit that referenced this issue Jun 1, 2022
@tmclo @jimmywarting
fix: use space in accept-encoding values (#1572)
a92b5d5 
* fix for issue #1571

* Update README.md

Co-authored-by: Jimmy Wärting <jimmy@warting.se>
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

🎉 This issue has been resolved in version 3.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use space in accept-encoding values tmclo/node-fetch
2 participants
@LinusU @AlttiRi