Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined reference to response.body when aborted #1578

Merged
merged 1 commit into from Jun 9, 2022

Conversation

krisives
Copy link
Contributor

@krisives krisives commented Jun 9, 2022

Purpose

Fixes a bug where response.body doesn't exist during some portion of the request lifespan (likely when aborted manually)

Changes

Check if both response and response.body exist before trying to destroy.


  • I updated readme
  • I added unit test(s)

Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jimmywarting jimmywarting merged commit 1c5ed6b into node-fetch:main Jun 9, 2022
@github-actions
Copy link

github-actions bot commented Jun 9, 2022

🎉 This PR is included in version 3.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants