From 4e79458c69d090bd5cd141423fcb528f6fa5f7a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jimmy=20Wa=CC=88rting?= Date: Tue, 27 Jul 2021 17:31:01 +0200 Subject: [PATCH 1/9] Updated the PR template --- .github/PULL_REQUEST_TEMPLATE.md | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a2a4e111c..170dd2beb 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,20 +1,23 @@ - -- If you're fixing a bug, ensure you add unit tests to prove that it works. -- Before adding a feature, it is best to create an issue explaining it first. It would save you some effort in case we don't consider it should be included in node-fetch. -- If you are reporting a bug, adding failing units tests can be a good idea. ---> +## The purpose of this pull is: +... -**What is the purpose of this pull request?** +## This is what had to change: +... -- [ ] Documentation update -- [ ] Bug fix -- [ ] New feature -- [ ] Other, please explain: +## This is what like reviewers to know: +... -**What changes did you make? (provide an overview)** -**Which issue (if any) does this pull request address?** -**Is there anything you'd like reviewers to know?** + + +- [ ] I prefixed the PR-title with `docs: `, `fix(area): `, `feat(area): ` or `breaking(area): ` +- [ ] I updated ./docs/CHANGELOG.md with a link to this PR or Issue +- [ ] I updated ./docs/v3-UPGRADE-GUIDE +- [ ] I updated the README.md +- [ ] I Added unit test(s) + + +- fix #0 From 7496acb5b553a7e6dd4a7b799ec387c057eb1ce5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jimmy=20Wa=CC=88rting?= Date: Tue, 27 Jul 2021 17:39:09 +0200 Subject: [PATCH 2/9] shorter variant --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 170dd2beb..3082b5aa9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,6 +1,6 @@ -## The purpose of this pull is: +## The purpose of this PR is: ... ## This is what had to change: From f391036c819c4bc694bb33243d500607e03fd457 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jimmy=20Wa=CC=88rting?= Date: Tue, 27 Jul 2021 17:55:30 +0200 Subject: [PATCH 3/9] Added a line break --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3082b5aa9..5583cd893 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,7 +10,7 @@ ... - +------------------------------------------------------------------------------------------------- - [ ] I prefixed the PR-title with `docs: `, `fix(area): `, `feat(area): ` or `breaking(area): ` From df187993b069f26222f6e9da903a5174e4ee2670 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jimmy=20Wa=CC=88rting?= Date: Wed, 28 Jul 2021 01:24:18 +0200 Subject: [PATCH 4/9] rm taskmaster --- .github/PULL_REQUEST_TEMPLATE.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5583cd893..1a1d6fccc 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -12,12 +12,14 @@ ------------------------------------------------------------------------------------------------- - + - [ ] I prefixed the PR-title with `docs: `, `fix(area): `, `feat(area): ` or `breaking(area): ` - [ ] I updated ./docs/CHANGELOG.md with a link to this PR or Issue - [ ] I updated ./docs/v3-UPGRADE-GUIDE - [ ] I updated the README.md - [ ] I Added unit test(s) +------------------------------------------------------------------------------------------------- + -- fix #0 +- fix #000 From 8c26dff2658b6e494dc6b81829562ec9bb51f81d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jimmy=20Wa=CC=88rting?= Date: Wed, 28 Jul 2021 01:37:59 +0200 Subject: [PATCH 5/9] Suggest adding unfinished tasks --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1a1d6fccc..1348484f0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -12,7 +12,7 @@ ------------------------------------------------------------------------------------------------- - + - [ ] I prefixed the PR-title with `docs: `, `fix(area): `, `feat(area): ` or `breaking(area): ` - [ ] I updated ./docs/CHANGELOG.md with a link to this PR or Issue - [ ] I updated ./docs/v3-UPGRADE-GUIDE From 3f84291a39b75e5b5e5265c86b6350039080eb41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jimmy=20Wa=CC=88rting?= Date: Thu, 5 Aug 2021 19:26:32 +0200 Subject: [PATCH 6/9] Shorter titles --- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1348484f0..4def3b4c4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,12 +1,12 @@ -## The purpose of this PR is: +## Purpose ... -## This is what had to change: +## Changes ... -## This is what like reviewers to know: +## Additional information ... @@ -17,9 +17,9 @@ - [ ] I updated ./docs/CHANGELOG.md with a link to this PR or Issue - [ ] I updated ./docs/v3-UPGRADE-GUIDE - [ ] I updated the README.md -- [ ] I Added unit test(s) +- [ ] I added unit test(s) ------------------------------------------------------------------------------------------------- - + - fix #000 From 6b598e8470bb572fe9378bca747dc2b6d849501e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jimmy=20Wa=CC=88rting?= Date: Fri, 6 Aug 2021 09:30:00 +0200 Subject: [PATCH 7/9] sorter lines --- .github/PULL_REQUEST_TEMPLATE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4def3b4c4..3e90444c7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,7 +10,7 @@ ... -------------------------------------------------------------------------------------------------- +___ - [ ] I prefixed the PR-title with `docs: `, `fix(area): `, `feat(area): ` or `breaking(area): ` @@ -19,7 +19,7 @@ - [ ] I updated the README.md - [ ] I added unit test(s) -------------------------------------------------------------------------------------------------- +___ - + - fix #000 From a6a70a297ea52648eebd88008ccef05b339735f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jimmy=20Wa=CC=88rting?= Date: Mon, 9 Aug 2021 12:09:39 +0200 Subject: [PATCH 8/9] rm title task --- .github/PULL_REQUEST_TEMPLATE.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3e90444c7..4efdc2709 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -13,7 +13,6 @@ ___ -- [ ] I prefixed the PR-title with `docs: `, `fix(area): `, `feat(area): ` or `breaking(area): ` - [ ] I updated ./docs/CHANGELOG.md with a link to this PR or Issue - [ ] I updated ./docs/v3-UPGRADE-GUIDE - [ ] I updated the README.md From a3deefcc9f097eb05c03e62f094272fed6123e75 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jimmy=20Wa=CC=88rting?= Date: Sat, 21 Aug 2021 19:16:20 +0200 Subject: [PATCH 9/9] convey more information in less words qouted by Richienb --- .github/PULL_REQUEST_TEMPLATE.md | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4efdc2709..59326bfe8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,24 +1,23 @@ ## Purpose -... + ## Changes -... + ## Additional information -... ___ - + - [ ] I updated ./docs/CHANGELOG.md with a link to this PR or Issue - [ ] I updated ./docs/v3-UPGRADE-GUIDE -- [ ] I updated the README.md +- [ ] I updated readme - [ ] I added unit test(s) ___ - -- fix #000 + +- Fixes #000