Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested Update to complete performance improvement fix #76

Open
ggryschuk opened this issue Sep 8, 2022 · 1 comment
Open

Suggested Update to complete performance improvement fix #76

ggryschuk opened this issue Sep 8, 2022 · 1 comment

Comments

@ggryschuk
Copy link

Hi. I've opened a new issue to submit the results of an update I've made to ref-napi to (hopefully) finalize the fix to performance started here #72. See my comments there in regards to an update needed to ReadPointer to account for needing to return a 1-length pointer. Specifically the following code needs to be added the 'reinterpret_cast',

if(val != nullPtr && size == 0) size = 1;

With this update made ref-napi will pass all it's mocha tests.

Importantly I've been able to identify the relatively simple updates needed to be made to ffi-napi to make it compatible with an updated ref-napi with these fixes. I will be posting my findings regarding ffi-napi over on the ffi-napi issues list.

Thanks.

@ggryschuk
Copy link
Author

My apologies that should read "...to be added AFTER the 'reinterpret_cast'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant