You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi. I've opened a new issue to submit the results of an update I've made to ref-napi to (hopefully) finalize the fix to performance started here #72. See my comments there in regards to an update needed to ReadPointer to account for needing to return a 1-length pointer. Specifically the following code needs to be added the 'reinterpret_cast',
if(val != nullPtr && size == 0) size = 1;
With this update made ref-napi will pass all it's mocha tests.
Importantly I've been able to identify the relatively simple updates needed to be made to ffi-napi to make it compatible with an updated ref-napi with these fixes. I will be posting my findings regarding ffi-napi over on the ffi-napi issues list.
Thanks.
The text was updated successfully, but these errors were encountered:
Hi. I've opened a new issue to submit the results of an update I've made to ref-napi to (hopefully) finalize the fix to performance started here #72. See my comments there in regards to an update needed to ReadPointer to account for needing to return a 1-length pointer. Specifically the following code needs to be added the 'reinterpret_cast',
if(val != nullPtr && size == 0) size = 1;
With this update made ref-napi will pass all it's mocha tests.
Importantly I've been able to identify the relatively simple updates needed to be made to ffi-napi to make it compatible with an updated ref-napi with these fixes. I will be posting my findings regarding ffi-napi over on the ffi-napi issues list.
Thanks.
The text was updated successfully, but these errors were encountered: