Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype Pollution Vulnerability #43

Closed
drewjenkins opened this issue May 23, 2018 · 2 comments
Closed

Prototype Pollution Vulnerability #43

drewjenkins opened this issue May 23, 2018 · 2 comments

Comments

@drewjenkins
Copy link

✗ Low severity vulnerability found on hoek@2.16.3

  • desc: Prototype Pollution
  • info: https://snyk.io/vuln/npm:hoek:20180212
  • from: canvas-prebuilt@1.6.5-prerelease.1 > node-pre-gyp@0.6.39 > request@2.81.0 > hawk@3.1.3 > cryptiles@2.0.5 > boom@2.10.1 > hoek@2.16.3

To resolve this, upgrade to node-pre-gyp >= 0.7.0
See mapbox/node-pre-gyp#347

@sizenineelm
Copy link

sizenineelm commented Aug 13, 2018

Vulnerability is still there through dependency versions:
-- canvas-prebuilt@1.6.5-prerelease.1 -- node-pre-gyp@0.6.39
-- hawk@3.1.3 +-- boom@2.10.1 | -- hoek@2.16.3 deduped
+-- hoek@2.16.3
-- sntp@1.0.9 -- hoek@2.16.3 deduped

node-pre-gyp has been updated to avoid its dependency issues, so only this needs updated.
https://nodesecurity.io/advisories/566

Edit to add: noted that the version of node-pre-gyp is updated to 0.10.0 in the v2.0.0-alpha branch.

@chearon
Copy link
Member

chearon commented Sep 10, 2018

Both the 1.6 series and 2.0 have node-pre-gyp 0.10 now

@chearon chearon closed this as completed Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants