Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add statusChanged getter #51

Merged
merged 1 commit into from Jun 20, 2017
Merged

feat: add statusChanged getter #51

merged 1 commit into from Jun 20, 2017

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 19, 2017

detect status changed or not

detect status changed or not
@@ -77,6 +89,24 @@ class Agent extends OriginalAgent {
});
}

get statusChanged() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先判断是否 status 变化了,避免大量 inspect 操作

@codecov
Copy link

codecov bot commented Jun 19, 2017

Codecov Report

Merging #51 into master will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage    93.1%   93.47%   +0.37%     
==========================================
  Files           4        4              
  Lines         261      276      +15     
==========================================
+ Hits          243      258      +15     
  Misses         18       18
Impacted Files Coverage Δ
lib/agent.js 95% <100%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6235a97...2cf5585. Read the comment docs.

@dead-horse dead-horse merged commit 427ab21 into master Jun 20, 2017
@dead-horse dead-horse deleted the add-statusChanged branch June 20, 2017 02:37
@dead-horse
Copy link
Member

@fengmk2 你发版本吧,我没权限

@fengmk2
Copy link
Member Author

fengmk2 commented Jun 20, 2017

3.3.0

@fengmk2
Copy link
Member Author

fengmk2 commented Jun 20, 2017

npm owner ls
dead-horse <dead_horse@qq.com>
dead_horse <dead_horse@qq.com>
fengmk2 <fengmk2@gmail.com>
popomore <sakura9515@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants