Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export interface for types #70

Merged
merged 1 commit into from Feb 12, 2019
Merged

Export interface for types #70

merged 1 commit into from Feb 12, 2019

Conversation

vinaybedre
Copy link
Contributor

Exporting interfaces for AgentStatus, HttpOptions and HttpsOptions

Exporting interfaces for AgentStatus, HttpOptions and HttpsOptions
@vinaybedre vinaybedre changed the title Export interface Export interface for types Jan 25, 2019
@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #70   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         174    174           
=====================================
  Hits          174    174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9124343...79d5d49. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #70   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         174    174           
=====================================
  Hits          174    174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9124343...79d5d49. Read the comment docs.

@vinaybedre
Copy link
Contributor Author

hey @fengmk2 Can you look into my MR and approve?

@fengmk2
Copy link
Member

fengmk2 commented Jan 28, 2019

@ngot can you take a look? I will merge it if you accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants