Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HttpsAgent Type Definition #72

Merged
merged 1 commit into from Feb 12, 2019

Conversation

AndrewLeedham
Copy link
Contributor

@AndrewLeedham AndrewLeedham commented Feb 7, 2019

fixes: #71

@AndrewLeedham AndrewLeedham changed the title fix: HttpsAgent Type Definition (#71) fix: HttpsAgent Type Definition Feb 7, 2019
@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #72   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         174    174           
=====================================
  Hits          174    174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9124343...9ca6ad2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #72   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         174    174           
=====================================
  Hits          174    174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9124343...9ca6ad2. Read the comment docs.

@fengmk2 fengmk2 requested a review from ngot February 12, 2019 06:51
@fengmk2 fengmk2 merged commit bad1ac0 into node-modules:master Feb 12, 2019
@AndrewLeedham
Copy link
Contributor Author

@fengmk2 Thanks for merging this, would it be possible to include this in a release on npm. I.e. 4.0.1?

@fengmk2
Copy link
Member

fengmk2 commented Feb 19, 2019

4.0.1 Released now! @AndrewLeedham sorry for the delay.

@AndrewLeedham
Copy link
Contributor Author

AndrewLeedham commented Feb 19, 2019

Hmm @fengmk2, seeing a new error now:
image seems like #70 and #72 weren't compatible changes together.

See: #73 #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript https agent error
2 participants