Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change generator to warn about invalid argument names #1464

Open
rcjsuen opened this issue Mar 20, 2018 · 1 comment · May be fixed by #1467
Open

Change generator to warn about invalid argument names #1464

rcjsuen opened this issue Mar 20, 2018 · 1 comment · May be fixed by #1467

Comments

@rcjsuen
Copy link
Member

rcjsuen commented Mar 20, 2018

I had the following in my descriptor.json file:

          "args": {
            "result": {
              "isReturn": true
            },
            "opts:": {
              "isOptional": true
            }

I ran npm run generateJson and npm run generateNativeCode many times but the opts argument wouldn't become optional in the generated C++ file. I finally realized I made a typo. I named the argument opts: instead of opts! :(

We should change the generator so that it will generate warnings if a specified argument's name doesn't match what's declared in libgit2.

@rcjsuen
Copy link
Member Author

rcjsuen commented Mar 20, 2018

I've opened #1467 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant