Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building for Node 18 needs libssl-dev and libkrb5-dev to allow building libgit2 from source #1982

Open
wiceywkus opened this issue Jun 14, 2023 · 2 comments

Comments

@wiceywkus
Copy link

System information

  • node version: v16.18.1
  • npm or yarn version: npm 8.19.2
  • OS/version/architecture: Ubuntu: 5.15.90.1-microsoft-standard-WSL2 Comment all code methods #1 SMP Fri Jan 27 02:56:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
  • Applicable nodegit version: v0.28.0-alpha.21

I successfully installed v0.28.0-alpha.21 for Node 18.
To the base OS, I had to add:
sudo apt install libssl-dev libkrb5-dev

The install needs to actually build the libgit2 libraries for this work, so it is slower.

Any chance that the 0.28.0 release will be finalized and binary packages created for general use?

ChelseaKR added a commit to newjersey/dol-mcnj-main that referenced this issue Jul 10, 2023
@wiceywkus
Copy link
Author

Also, install with 0.28.0-alpha.23 does not work with Node v18.19.1. It does work with Node v18.16.1.
My system is Ubuntu on WSL2 on Win10 x64.
I every install scenario installs or build Win32 nodegit.node libraries.
Trying to debug with --update-binary and --build-from-source does not work either.
I did not try git clone and building from there.
I understand the download binary idea, but with Node shouldn't the v18.16.1 stuff work with v18.19.1 stuff?

@wiceywkus
Copy link
Author

FYI: I worked around the npm install problem, I think there was something that the install was inheriting from my shell or prior install that was triggering the Win32 path. Somehow I managed to reset it and it builds correctly now. So, nevermind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant