Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on polyfills? #23

Open
justinfagnani opened this issue Jun 29, 2016 · 2 comments
Open

Remove dependencies on polyfills? #23

justinfagnani opened this issue Jun 29, 2016 · 2 comments

Comments

@justinfagnani
Copy link

In relatively recent versions of Node, including the current LTS, object-assign and nodegit-promise are unnecessary. It'd be great if promisify-node didn't directly depend on polyfill (or polyfill-like in the case of object-assign) libraries and instead required that the environment provide them if necessary.

@maxkorp
Copy link
Contributor

maxkorp commented Jun 30, 2016

nodegit-promise is not unnecessary. it has custom promise implementation that allows us to synchronously poll it's state in C++, which is not available with the built in promise implementation.
Object assign probably yeah, although how long has that been in? We're staying supporting node 4 since it's LTS.

@heyimalex
Copy link

FYI, Object.assign is definitely in node v4. Check out node.green for a decent feature support table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants