Plan for Node.js 11 Current releases #397
Comments
|
I'd personally be more comfortable with the releases happening on
Tuesday... Would you be open to making that change?
…On Sat, Dec 8, 2018, 9:52 AM Michaël Zasso ***@***.*** wrote:
Week Approximative date Releaser
2018 - 51 2018-12-19 @BethGriggs <https://github.com/BethGriggs>
2019 - 02 2019-01-09 ???
2019 - 04 2019-01-23 ???
2019 - 06 2019-02-06 ???
2019 - 08 2019-02-20 ???
2019 - 10 2019-03-06 ???
2019 - 12 2019-03-20 ???
2019 - 14 2019-04-03 ???
2019 - 16 2019-04-17 ???
/cc @nodejs/releasers <https://github.com/orgs/nodejs/teams/releasers>
I propose this plan for the next Node.js 11 Current releases, until the
week before Node.js 12 is supposed to be released.
It's a simple rule: one release every two weeks, with an exception of
three weeks during end of year holidays. I always put Wednesday as
approximative date but the release could happen any day of the week,
depending on releaser's availability.
We already have a volunteer <#395>
to do the next release. @BethGriggs <https://github.com/BethGriggs> is
week 51 OK for you?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#397>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAecV6va8riTLov0wMZDusJaY-nHgYj0ks5u29IngaJpZM4ZJq0p>
.
|
|
@MylesBorins OK, I changed the dates... But those should not be considered fixed. I personally have more time to do releases on Wednesdays or Thursdays. |
|
I suggest to use the dates as recommendation and let the releasing person be flexible with the actual day while trying to prevent releases on Fridays. I am fine to volunteer for e.g., each even 11 release. That way I know when to take some time for it. |
|
@BridgeAR I generally push for releases on Tuesday for 2 reasons
While I totally understand the timing issue here, my hope would be that the majority of release work has been done in advance, a least multiple days in advance. So, for example, a release can be prepared and proposed on a Thursday so that testing can begin. This was the only work to be done on tuesday is promotion... which "shouldn't" take more than an hour. |
|
I volunteer for 2019-01-22 |
|
Ping @nodejs/releasers do we have a volunteer for this week? It would be nice to have a patch release with npm 6.5.0 stable. |
|
I'll prepare the release tomorrow. |
|
how goes today's patch release? :-D |
|
@ljharb currently there are lots of conflicts between master and 11.x and I did not get to resolve all of these and I have to get some sleep but I'll try to finish it tomorrow. It's likely that we should backport a couple of older commits first though. Otherwise each release is going to become more complicated. |
|
I'm most interested in seeing nodejs/node#25234 make it into an 11.6 patch release; as long as it doesn't get delayed to an 11.7, i'm more than happy to wait til you have time :-) Thanks! |
|
@ljharb that one is already on staging 🎉
…On Tue, Jan 8, 2019, 8:05 PM Jordan Harband ***@***.*** wrote:
I'm most interested in seeing nodejs/node#25234
<nodejs/node#25234> make it into an 11.6 patch
release; as long as it doesn't get delayed to an 11.7, i'm more than happy
to wait til you have time :-) Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#397 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAecV1hT21uU_361beeclh63oaa8pzP1ks5vBUBGgaJpZM4ZJq0p>
.
|
|
@BridgeAR are you still able to do this? |
|
I opened a release proposal for 11.7.0 (should this be a semver-patch release? If so, it'll we a tiny release as we had quite some issues backporting things and it would require more time to resolve further conflicts. Right now we are back on track with the conflicts and have only few backport requests to 11.x). |
|
My hope is for a patch release. |
|
@ljharb why a patch release? We have brotli and a number of semver-minor commits I'm personally -1 on doing a patch release, it isn't the process we've done in the past for current and will significantly complicate landing a bunch of stuff. |
|
I mean obv if there’s additions it should be a minor; it’s just disappointing since a patch release with the npm fix should have been able to go out before landing those. |
|
@targos since the release took somewhat longer due to backporting a lot of things that caused conflicts: it's probably best to move the release after 11.7.0 by one week or skip the release. |
|
OK, I shifted everything by one week. In the future, I think it will be better to stick with the schedule and avoid blocking on pending backports. Current releases happen often enough that we can postpone backports to the next one. |
|
Can anyone prepare a release for this week? |
|
I found some time to do it today: nodejs/node#26098 |
|
Should we release the next current (v11) version next week or the week after? It was originally planned to release it this week but it was postponed due to the security release. I personally suggest to release it on next Tuesday but I do not know how everyone else feels about it. |
|
I have no objection to doing releases two weeks in a row (if there are enough commits to warrant it). |
|
Next week sounds good to me. In general a weekly cadence for Current is
absolutely fine I'd there are enough commits
…On Fri, Mar 1, 2019, 9:40 AM Michaël Zasso ***@***.***> wrote:
I have no objection to doing releases two weeks in a row (if there are
enough commits to warrant it).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#397 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAecV6eBJvfV_YWbJT9Km_sUU20zyauLks5vSTvhgaJpZM4ZJq0p>
.
|
|
I updated the staging branch today to get a release proposal together but that took quite a bit due to lots of conflicts and bisecting in-between. I would like to release a new version tomorrow if no one is against it, since a fix for jest just landed. Any opinions @nodejs/releasers? |
|
FYI, I linked to this from https://github.com/nodejs/Release/wiki |
|
@codebytere During yesterday's meeting, we decided to move the last active release of v11.x to 2019-04-16 so it doesn't happen the same week as 12.0.0. Is it still OK for you? |
|
Currently prepping today's release, aim to open the PR later this evening and have it go out tomorrow |
|
@codebytere Do you have time to prepare this week's release? If not I can do it. |
|
For now, I've based the v12.0.0 release changelog on the diff between v11.14.0 and v12.x. Some PRs have landed on 11.x-staging that would be good to ship (even if that happens to be after v12.x goes out). |
|
@BethGriggs just for understanding since I somewhat read both: is it only about the changelog or are commits missing that landed on the 11 branch? |
|
Ah sorry, in regards to Node 12 it is just the changelog. As far as I know, all new commits currently on v11.x-staging are manual v11.x backports. |
|
The final planned release is next week. I'm thinking that if there is a demand or a request for some specific fixes/backports we could do another release before v11.x goes End-of-Life on 2019-06-01 to tie up any loose ends. |
|
+1 |
/cc @nodejs/releasers
I propose this plan for the next Node.js 11 Current releases, until the week before Node.js 12 is supposed to be released.
It's a simple rule: one release every two weeks, with an exception of three weeks during end of year holidays. I always put Tuesday as approximative date but the release could happen any day of the week, depending on releaser's availability.
We already have a volunteer to do the next release. @BethGriggs is week 51 OK for you?
The text was updated successfully, but these errors were encountered: