Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM issue on 12.x requires a quick 12.16.1 #532

Closed
MylesBorins opened this issue Feb 13, 2020 · 3 comments
Closed

ESM issue on 12.x requires a quick 12.16.1 #532

MylesBorins opened this issue Feb 13, 2020 · 3 comments

Comments

@MylesBorins
Copy link
Member

Hey All. It turns out the backporting of ESM to 12.x introduced a regression, specifically the "self resolution" feature is working without a flag, which is not intentional.

nodejs/node#31754

I want to get a 12.16.1 out today if possible to fix this one problem. Any conerns?

/cc @nodejs/lts @nodejs/tsc

@richardlau
Copy link
Member

There were a couple of other regressions introduced in 12.16.0 too:

@MylesBorins
Copy link
Member Author

PTAL at nodejs/node#31782 which reverts the changes that caused the issues.

@addaleax
Copy link
Member

@MylesBorins @richardlau

* [nodejs/node#31752](https://github.com/nodejs/node/issues/31752), which @addaleax is looking at but perhaps we could revert [nodejs/node@65e5a8a](https://github.com/nodejs/node/commit/65e5a8a90cd85fc4d9036bc4b54e0905edd8b51a)?

I would strongly prefer not to. This fixed a real bug. A partial revert for the changes in node_main_instance.cc should be okay, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants