Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HackerOne policy and Response Targets #1129

Closed
Trott opened this issue Nov 24, 2021 · 4 comments · Fixed by nodejs/node#40968
Closed

update HackerOne policy and Response Targets #1129

Trott opened this issue Nov 24, 2021 · 4 comments · Fixed by nodejs/node#40968

Comments

@Trott
Copy link
Member

Trott commented Nov 24, 2021

While this policy and these response targets may (or may not) have been realistic when HackerOne was helping directly with triage, that is no longer the case and we need to update this.

Policy

Reporting a Bug in Node.js

All security bugs in Node.js are taken seriously. Please report any security issues here.

Your report will be acknowledged within 24 hours, and you’ll receive a more detailed response within 48 hours indicating the next steps in handling your report.

After the initial reply to your report, the security team will endeavor to keep you informed of the progress being made towards a fix and full announcement, and may ask for additional information or guidance surrounding the reported issue. These updates will be sent at least every five days, in practice, this is more likely to be every 24-48 hours.

Reporting a Bug in a third party module

Third-party modules are no longer handled by the Node.js security-group. Vulnerabilities in npm packages should be reported directly to the package maintainers. We strongly advise doing this privately. You can find contact information about package maintainers with npm owner ls . If the source code is hosted on GitHub please refer to the repository's Security Policy.

Disclosure Policy

Here is the security disclosure policy for Node.js

  • The security report is received and is assigned a primary handler. This person will coordinate the fix and release process. The problem is confirmed and a list of all affected versions is determined. Code is audited to find any potential similar problems. Fixes are prepared for all releases which are still under maintenance. These fixes are not committed to the public repository but rather held locally pending the announcement.

  • A suggested embargo date for this vulnerability is chosen and a CVE (Common Vulnerabilities and Exposures (CVE®)) is requested for the vulnerability.

  • On the embargo date, the Node.js security mailing list is sent a copy of the announcement. The changes are pushed to the public repository and new builds are deployed to nodejs.org. Within 6 hours of the mailing list being notified, a copy of the advisory will be published on the Node.js blog.

  • Typically the embargo date will be set 72 hours from the time the CVE is issued. However, this may vary depending on the severity of the bug or difficulty in applying a fix.

  • This process can take some time, especially when coordination is required with maintainers of other projects. Every effort will be made to handle the bug in as timely a manner as possible, however, it’s important that we follow the release process above to ensure that the disclosure is handled in a consistent manner.

Receiving Security Updates

Security notifications will be distributed via the following methods.

Comments on this Policy

If you have suggestions on how this process could be improved, please submit a pull request or file an issue.

Thank you for improving the security of Node.js and its ecosystem. Your efforts and responsible disclosure are greatly appreciated and will be acknowledged.

Internet Bug Bounty Qualification

The Internet Bug Bounty awards security research on Node.js. If your vulnerability meets the eligibility criteria, you can submit the post-fix information to the IBB for payout. As the IBB supports the whole vulnerability lifecycle, these bounty awards are awarded as an 80/20 split, where 80% will go to you, the finder, and 20% will be given to Node.js to continue to support the vulnerability remediation efforts.

Only vulnerabilities in Node.js core will be considered for eligibility. Submissions related to nodejs.org and other project websites are explicitly NOT eligible.

To submit eligible vulnerabilities for a payout go to https://hackerone.com/ibb for submission instructions after the project maintainers have resolved the vulnerability.

Project Modifiers. Bounty amounts for this project are adjusted based on the following criteria:

-50% : Vulnerability is not exploitable in a default configuration of Node.js

-25%: A proposed patch was not provided for the issue

Reminder, be professional! 💼 Any report of abuse or unprofessional conduct when working with Node.js Maintainers will result in the finder being ineligible for the IBB bounty reward. For example, threats of bad publicity, lack of interest in pragmatic exploitability discussions, refusal to be an active participant in moving resolution forward.

These modifiers are designed to encourage research into the most impactful areas. They are subject to change at any time by the project maintainers.

The project maintainers have final decision on which issues constitute security vulnerabilities. The IBB team will respect their decision, and we ask that you do as well.

Response Targets

image

@Trott
Copy link
Member Author

Trott commented Nov 24, 2021

For the Response Targets, I propose that we use the values in the Standard column: 5 days for a first response, 10 days to triage, and no values provided for time to bounty or time to resolution.

@Trott
Copy link
Member Author

Trott commented Nov 24, 2021

I also propose that we do not duplicate information in the Response Targets in the Policy. There's no need to mention the targets for first response or triage in the policy (or at least no need to mention their values) because they are set on the program itself.

@Trott
Copy link
Member Author

Trott commented Nov 24, 2021

I think what we need here is someone to volunteer to edit the Policy. I think that person will likely need to be someone who has been involved in triage work recently, so that would mean @mcollina @vdeturckheim and/or @mhdawson. I'm happy to help, if having a pair session on editing it is useful.

@mcollina
Copy link
Member

Here is PR to update the policy on our end: nodejs/node#40968.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants