Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating Chengzhong Wu (@legendecas) to the TSC #1282

Closed
mhdawson opened this issue Sep 8, 2022 · 22 comments
Closed

Nominating Chengzhong Wu (@legendecas) to the TSC #1282

mhdawson opened this issue Sep 8, 2022 · 22 comments

Comments

@mhdawson
Copy link
Member

mhdawson commented Sep 8, 2022

I'd like to nominate Chengzhong Wu (@legendecas)[https://github.com/legendecas].

He has contributed over a number of years and has 83 commits to Node.js core, has been involved in 440 issues in node.js core and is a significant contributor to Node-api and the work of the Node-api team. He has also been contributing to diagnostic efforts and is leading the ShadowRealm initiative.

He's been very collaborative, contributes in a thoughtful and respectful way, and works to help move the work of the project forward in a scope greater than individual commits/issues. I've enjoyed my interactions with him and I think he'd be a good addition to the TSC.

@aduh95
Copy link
Contributor

aduh95 commented Sep 8, 2022

+1 assuming is up for it :)

@mhdawson
Copy link
Member Author

mhdawson commented Sep 8, 2022

I should have mentioned I have talked to Chengzhong and he is interested.

@richardlau
Copy link
Member

+1

3 similar comments
@Trott
Copy link
Member

Trott commented Sep 8, 2022

+1

@apapirovski
Copy link
Member

+1

@gireeshpunathil
Copy link
Member

+1

@RaisinTen
Copy link
Contributor

+1 for sure!

@targos
Copy link
Member

targos commented Sep 9, 2022

+1

2 similar comments
@BethGriggs
Copy link
Member

+1

@joyeecheung
Copy link
Member

+1

@mhdawson
Copy link
Member Author

By my count we have 14/20 +1s so far and no objections.

I will wait until after the TSC meeting this week and then close the vote (The goverance says The TSC may add additional members to the TSC by a standard TSC motion and vote.) and the +1's emoji's in this issue will be tallied to get the vote results after the TSC meeting.

I'll volunteer to onboard @legendecas assuming the vote is positive. Anybody else want to join us?

@mhdawson
Copy link
Member Author

Ok, TSC meeting passed, and no objections so considering vote complete with a yes. PR to add vote data - #1284

@mhdawson
Copy link
Member Author

mhdawson commented Sep 15, 2022

@legendecas I'll co-ordinate with you for the onboarding separately:

  • Confirm that the new member has read, understands, and agrees to uphold the
    Code of Conduct.
  • Add the new member to the @nodejs/tsc and @nodejs/security-tsc teams.
  • Change the new member's role in the GitHub nodejs organization to Owner.
  • Add them to the @nodejs-private org and with an Owner role.
  • Add them to the @nodejs-private/security-tsc team.
  • Add them to the @pkgjs org and with an Owner role.
  • Add them to the @pkgjs/node-tsc team.
  • Invite them to the HackerOne Node.js team.
    Have them turn on two-factor authentication after they have joined.
  • Add them to the tsc and crypto-export mailing lists.
  • Add them to the nodejs-tsc Google Group as owners, so they receive Calendar invites for TSC meetings.
  • Update the @nodejs/node repository README to reflect membership in the TSC.
  • Update https://github.com/nodejs/create-node-meeting-artifacts/blob/main/templates/invited_tsc to reflect membership in the TSC.

@mhdawson
Copy link
Member Author

@legendecas can you confirm:

Confirm that the new member has read, understands, and agrees to uphold the
Code of Conduct.

@mhdawson
Copy link
Member Author

PR to add Chengzhong to invited list for TSC meetings - https://github.com/nodejs/create-node-meeting-artifacts/pull/118/files

@mhdawson
Copy link
Member Author

PR to add to mailing lists - nodejs/email#197

@mhdawson
Copy link
Member Author

PR to add to TSC list in README.md - nodejs/node#44662

mhdawson added a commit to mhdawson/io.js that referenced this issue Sep 15, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@legendecas
Copy link
Member

Confirm that the new member has read, understands, and agrees to uphold the
Code of Conduct.

I confirm I understand and agree to uphold the code of conduct.

mhdawson added a commit to mhdawson/io.js that referenced this issue Sep 15, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
Copy link
Member Author

Working through the list, only a few more items that I should get to tomorrow. @legendecas maybe we can talk after the Node-API team meeting tomorrow and I can give you some context and answer any questions you have?

@legendecas
Copy link
Member

Working through the list, only a few more items that I should get to tomorrow. @legendecas maybe we can talk after the Node-API team meeting tomorrow and I can give you some context and answer any questions you have?

Sure, that will be great, thank you!

mhdawson added a commit to nodejs/node that referenced this issue Sep 16, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 17, 2022

I think the only thing left to do is to add @legendecas to HackerOne (and maybe to the Google Group--I didn't check that one).

@mhdawson Let me know if you want me to handle HackerOne or find someone to handle the Google Group. Otherwise, I'll assume you're waiting to talk to @legendecas about something first or something like that.

@mhdawson
Copy link
Member Author

Ok all done.

RafaelGSS pushed a commit to nodejs/node that referenced this issue Sep 26, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Sep 26, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit to nodejs/node that referenced this issue Sep 26, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 4, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 4, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 4, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 7, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 10, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 11, 2022
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs/node#44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
Refs: nodejs/TSC#1282

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs/node#44662
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests