Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of potential N-API breaking changes #271

Closed
jasongin opened this issue Aug 1, 2017 · 3 comments
Closed

List of potential N-API breaking changes #271

jasongin opened this issue Aug 1, 2017 · 3 comments

Comments

@jasongin
Copy link
Member

jasongin commented Aug 1, 2017

After N-API exits experimental status, we can no longer make breaking changes. So we should track any issues that might force breaking changes, to ensure they are resolved before then. Here are the ones that I am aware of:

@jasongin
Copy link
Member Author

jasongin commented Sep 4, 2017

The changes for async hooks are in 2 PRs: nodejs/node#14697, nodejs/node#15189

@mhdawson
Copy link
Member

Now just waiting on nodejs/node#15108
@sampsongao will add the tests tonight and hopefully we can land Friday Sep 15

@mhdawson
Copy link
Member

We've done what we were going to do on this front, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants