Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports for tsfn #358

Closed
mhdawson opened this issue Jan 17, 2019 · 5 comments
Closed

Backports for tsfn #358

mhdawson opened this issue Jan 17, 2019 · 5 comments
Milestone
Milestone 11

Comments

@mhdawson
Copy link
Member

Need to backport to 8.x and 10.x and make non experimental to help adoption.
@mhdawson mhdawson added this to the Milestone 11 milestone Jan 17, 2019
@mhdawson
Copy link
Member Author

mhdawson commented Jan 17, 2019 •
edited

Gabriel - already in as experimental in 10.X

Steps:

  1. Make non-experimental in master
  2. roll back to 10.x and 8.x

Gabriel will get the ball rolling.

@gabrielschulhof
Copy link
Collaborator

v10.x backport: nodejs/node#25633
v8.x backport: nodejs/node#25648

@mhdawson
Copy link
Member Author

From the meeting today sounds like there is a problem with FreeBSD 10 in the 10.x staging and release branches. Believe its the same problem that I refereed to in nodejs/node#25574.

@gabrielschulhof
Copy link
Collaborator

The commit on v10.x-staging that seems to have introduced the failure to compile on FreeBSD 10 is this: nodejs/node@acf7e7d

@mhdawson mhdawson mentioned this issue Jan 28, 2019
Closed
3 tasks
@gabrielschulhof
Copy link
Collaborator

These backports have now landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Milestone 11
Development

No branches or pull requests
2 participants
@gabrielschulhof @mhdawson