Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-API 7 #402

Closed
gabrielschulhof opened this issue Aug 3, 2020 · 4 comments
Closed

N-API 7 #402

gabrielschulhof opened this issue Aug 3, 2020 · 4 comments
Milestone

Comments

@gabrielschulhof
Copy link
Collaborator

Might it be time for a new version of N-API?

We have the buffer detaching stuff marked as experimental in all three LTS releases, so we could just define these APIs as N-API 7.

We also have type-tagging and asynchronous env cleanup coming on master, but those still need to be backported. As v10.x approaches EOL it is increasingly unlikely that they will be backported all the way there. Thus, it might make sense to sync our N-API version bump with the EOL of 10.x.

Shall we formalize and document our policy for moving APIs out of experimental and into a stable version of N-API?

@gabrielschulhof gabrielschulhof added this to the Milestone 11 milestone Aug 3, 2020
@mhdawson
Copy link
Member

We agreed:

  • that we should make buffer detaching stable in N-API 7
  • that type-tagging and async env cleanp should wait until N-API 8, possibly around the Node.js 16.x release timeline.

@gabrielschulhof
Copy link
Collaborator Author

@Flarna asked that nodejs/node#35214 be folded into N-API 7 because it's such a small change. Let's discuss at our next meeting.

@mhdawson mhdawson changed the title Discussion: N-API 7 N-API 7 Sep 25, 2020
@mhdawson
Copy link
Member

All ready to go, just waiting next 10.x release and then we can close this.

@mhdawson
Copy link
Member

Landed in 10.x, done !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants