Move node-pr-labeler into the nodejs organization

[phillipj]

As a step in modernizing the work our @nodejs-github-bot is doing in the nodejs/node repo, its PR labelling functionality has been extracted into a custom GitHub Action: phillipj/node-pr-labeler.

The main goal of that project is to put the labelling rules (filepaths -> labels) inside the nodejs/node repo, as a static config file, instead of being part of the nodejs/github-bot source code.

Any thoughts?

Refs nodejs/github-bot#294

/cc @nodejs/community-committee @nodejs/tsc @nodejs/github-bot

[richardlau]

Does this need a special token to label PR's from forks? I'm asking because the commit queue workflow did labelling and was disabled back in January because the token stopped working (nodejs/node#34770 (comment)). AFAIK only the owners (👋 @nodejs/tsc ) would be able to fix that so probably worth pointing out if that's extra responsibility the TSC needs to be aware they're taking on.

(I'm broadly supportive of the idea, btw, as in theory there's even less people able to update the bot (thanks @phillipj for keeping it updated and running ❤️).)

[nschonni]

Is there much custom than some of the existing solutions like https://github.com/marketplace/actions/labeler that make sense to maintain a separate one?

Edit: Mentioned in nodejs/github-bot#294 (comment)

[mhdawson]

+1

[bnb]

Would this make more sense under the pkgjs org? That seems to be where much of our tooling like this is now living.

[bnb]

AFAIK only the owners (👋 @nodejs/tsc ) would be able to fix that so probably worth pointing out if that's extra responsibility the TSC needs to be aware they're taking on.

CommComm chairperson is also an owner 😅

[phillipj]

Would this make more sense under the pkgjs org?

node-pr-labeler could in practise be used by any GitHub repo, as it's just another Action after all. But there's quite a lot of logic related to nodejs/node' subsystems labels, needs-ci and the use of lib / src label when too many labels has matched the files changed (refs node-pr-labeler /lib/resolve-labels.js).

I imagine that logic being less interesting for other repos, and from a distance the pkgjs org seems pretty generic for JavaScript tooling? Shoot me down if I'm wrong, I'm certainly not opinionated about where and I hadn't heard about that org until now 😄

[phillipj]

Does this need a special token to label PR's from forks? I'm asking because the commit queue workflow did labelling and was disabled back in January because the token stopped working ..

I honestly don't fully understand what happened back then, but I forked my proof-of-concept repo and opened this PR from that fork: phillipj/node-lookalike#14.

From what I can see, it works as expected. And that's without any token added in Settings of the phillipj/node-lookalike repo.

Let me know if that doesn't answer your concern.

[mhdawson]

Had discussed in the package maintenance meeting and I think we agreed it fits best with the Node.js org.

[phillipj]

Anything thing I can do to help make a decision here?

Like getting confirmation from nodejs/node collaborators by opening a PR adding using of node-pr-labeler etc? I assumed that would be premature before making the move into the nodejs org, but I might obviously be totally wrong.

[mmarchini]

+1 to move it to nodejs org, and thank you for working on this! It's a great step towards. It seems the repository already has the suggested files, so you just need to transfer it to the org and an Admin will approve it (you can let me know here and I can approve it, for example).

AFAIK only the owners (👋 @nodejs/tsc ) would be able to fix that

This is already true for the bot today, but the access to the server is even more limited. Moving to Actions should allow more folks to help fix things when they break.

[phillipj]

Thanks @mmarchini! I initiated the move now.

EDIT: which seemed to have immediate effect, even tho I'm not an org admin? 🤷🏻‍♂️ nodejs/node-pr-labeler

[phillipj]

Closing this issue since the repository has been moved into the org now.

Assigned privileges to the @nodejs/github-bot team, since that's where majority of the code originated from. Feel free to change that if you'd prefer otherwise.