Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer DataDog/import-in-the-middle to the org #858

Open
bengl opened this issue Mar 18, 2024 · 13 comments
Open

Transfer DataDog/import-in-the-middle to the org #858

bengl opened this issue Mar 18, 2024 · 13 comments

Comments

@bengl
Copy link
Member

bengl commented Mar 18, 2024

Several years ago, we (Datadog) created import-in-the-middle. Modeled after require-in-the-middle, it provides a simple layer for intercepting module loading using roughly the same API as require-in-the-middle, but for ESM, using Node.js loaders. It also manages differences in the loader API across Node.js versions, since our users use a wide range of Node.js versions with ESM.

The project has been a resounding success, and is now in use by several other organizations in the APM space, such as Elastic, NewRelic and OpenTelemetry. As a result, these other groups have submitted PRs, and been helpful in collaborating. At this point, we'd like to open it up even further, handing over governance of the project to a wider group, to ensure that Datadog is not a blocker for releases or maintenance.

Rather than form a separate entity/org to own this, we think that the Node.js org is an ideal place for this library to live. To that end, we're requesting a transfer from the DataDog GitHub org to the nodejs GitHub org, with governance by the TSC, but delegated to the Diagnostics WG. This governance structure aligns with other projects in this GitHub org.

Anticipated Questions

  • Why this org and not another one, like OpenTelemetry?
    • The Node.js project already shows a commitment to observability, and while OpenTelemetry might seem like another good home, we think import-in-the-middle is much lower-level than OpenTelemetry (in much the same way diagnostics_channel is), and has use cases outside of OpenTelemetry's scope.
  • Why this org and not a higher-level scope, like OpenJSF?
    • We think that the correct scope for import-in-the-middle is Node.js, since the library can only be used with Node.js, and exists only in that ecosystem.
  • Why the Diagnostics WG?
    • There's already a lot of overlap between the Diagnostics WG and the set of stakeholders in import-in-the-middle. Primarily this means APM vendors. That said, if desired, a new team could be formed specifically for maintenance of import-in-the-middle, initially composed of its most frequent comitters. This team could also be under the Diagnostics WG's purvey.
@bengl
Copy link
Member Author

bengl commented Mar 18, 2024

cc @nodejs/tsc

@mcollina
Copy link
Member

SGTM

2 similar comments
@ShogunPanda
Copy link

SGTM

@mhdawson
Copy link
Member

SGTM

@richardlau
Copy link
Member

+1

@BridgeAR
Copy link
Member

SGTM

@Qard
Copy link
Member

Qard commented Apr 16, 2024

@bengl What remains to be done here? Can we press the button now?

@anonrig
Copy link
Member

anonrig commented Apr 26, 2024

@bengl Can you initiate the transfer to the Node.js organization?

@bengl
Copy link
Member Author

bengl commented Apr 30, 2024

We're happy to transfer it, so long as the receiving party (@nodejs/tsc, or more likely @nodejs/diagnostics?) indicates that it is prepared to maintain it.

@anonrig
Copy link
Member

anonrig commented Apr 30, 2024

I'm interested in maintaining it.

cc @nodejs/tsc wdyt?

@Qard
Copy link
Member

Qard commented Apr 30, 2024

As a representative of @nodejs/diagnostics I think we're good with owning that, but of course contributors need to exist for maintenance to happen.

@tony-go
Copy link
Member

tony-go commented May 6, 2024

+1 :)

Also interested in maintaining it 💪🏼

@jsumners-nr
Copy link

On behalf of the Node.js agent team at New Relic, I am willing to participate as a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants