Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-test-commit-v8-linux: use test-nearform_intel-ubuntu1604-x64-1 instead of infra-softlayer-ubuntu1404-x64-2 #1381

Closed
mmarchini opened this issue Jun 22, 2018 · 4 comments
Assignees
Milestone

Comments

@mmarchini
Copy link
Contributor

While trying to fix the CI issues reported in nodejs/node#21334 I found out we use an infra-softlayer-ubuntu1404-x64-2 in node-test-commit-v8-linux. This is an infra machine, so not everyone from the Build WG has access to it. Since this is a test job and is run quite frequently, it would be a good idea to change the machine to a test machine. @refack suggested test-nearform_intel-ubuntu1604-x64-1.

I added test-nearform_intel-ubuntu1604-x64-1 to node-test-commit-v8-linux, but kept infra-softlayer-ubuntu1404-x64-2 since I was not sure if we needed to support Ubuntu 14.04 in that job. Can we remove infra-softlayer-ubuntu1404-x64-2 from node-test-commit-v8-linux, or should we keep it?

@mhdawson
Copy link
Member

For history, we used the benchmarking machine initially (which is now infra-softlayer-ubuntu1404-2) to avoid interference with regular CI runs.

We want the job to run on at least one x86 linux box. I like having it run on an older OS versus a newer one as it may be more likely to expose issues as V8 continues to push forward with using newer compiler (and possibly OS) features.

@mmarchini
Copy link
Contributor Author

@mhdawson thanks for the context! I don't have strong opinions regarding which machine we should use, as long as it's accessible by people with test-* credentials.

@mhdawson
Copy link
Member

The machine really should be benchmarking-xxxx but I'll have to see if it was always infra-xxx or was renamed to that for some reason along the way.

@refack
Copy link
Contributor

refack commented Apr 18, 2019

Since 1404 reached EOL I believe it's time to retire it from the job.

@refack refack self-assigned this Apr 18, 2019
@refack refack added this to todo in action items via automation Apr 18, 2019
@refack refack added this to the node12 milestone Apr 18, 2019
action items automation moved this from todo to done Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants