Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: have a machine run tests in an elevated env #1546

Closed
refack opened this issue Oct 23, 2018 · 2 comments
Closed

windows: have a machine run tests in an elevated env #1546

refack opened this issue Oct 23, 2018 · 2 comments

Comments

@refack
Copy link
Contributor

refack commented Oct 23, 2018

Refs: nodejs/node#23691
Refs: nodejs/node#23596

@refack refack changed the title windows: have a machine run test in elevated env windows: have a machine run tests in an elevated env Oct 23, 2018
@joaocgreis
Copy link
Member

Windows machines already run tests in an elevated environment, exactly because of this.

What happened with test-require-symlink was that the link was actually created and some programs like Node and Git Bash were actually able to use it. However, on Windows Explorer it appears as a useless .symlink file, suggested it was never meant to be used that way.

What probably broke the test was some recent Windows update. Node stopped being able to read the link, and the test started failing. We didn't see this in CI because we use Windows 10 Long Term Support Channel. I will see if we can use a different Windows 10 edition in CI to get more frequent updates.

@joaocgreis
Copy link
Member

The test was fixed by nodejs/node#23691 and the general case by nodejs/node#23724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants