Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node-test-commit-v8-linux to not overwrite make-v8.sh with a local copy #1857

Closed
sam-github opened this issue Jun 27, 2019 · 5 comments

Comments

@sam-github
Copy link
Contributor

Follow on from #1536, cc @refack @mhdawson

https://ci.nodejs.org/job/node-test-commit-v8-linux/ is copying over make-v8.sh from a local copy, with a note about upstreaming the changes.

But @refack already upstreamed the changes.

I modified the job config to not do the copy, I'll see how it goes: https://ci.nodejs.org/job/node-test-commit-v8-linux/2391/

I don't want to carry this hack over onto the new centos7 ppcle machines.

@mhdawson
Copy link
Member

+1 if the file is the same. I had thought that @refack had upstreamed.

@sam-github
Copy link
Contributor Author

Also TBD: The test-osuosl-ubuntu1404-ppc64 have copies of the pkg-config files in /home/iojs/build-tools/pkg-config-files, but the are identical to the system .pc files in /usr/lib/powerpc64le-linux-gnu/pkgconfig, they can be removed and the jenkins and make-v8.sh scripts simplified.

@sam-github
Copy link
Contributor Author

see: nodejs/node#28458

@sam-github
Copy link
Contributor Author

https://ci.nodejs.org/job/node-test-commit-v8-linux/2396/nodes=centos7-ppcle,v8test=v8test/console Its actually building v8, that's promising, will take a while to know if it suceeds in the test.

@sam-github
Copy link
Contributor Author

been more than a month with no complaints, must have worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants