Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

access for @victorgomes to osx build bot #1920

Closed
MylesBorins opened this issue Sep 19, 2019 · 21 comments
Closed

access for @victorgomes to osx build bot #1920

MylesBorins opened this issue Sep 19, 2019 · 21 comments

Comments

@MylesBorins
Copy link
Member

They are chasing down the issues in nodejs/node#29493 and want to see if they can get a patch together to get V8 7.8 working on our build machines.
@sam-github
Copy link
Contributor

@MylesBorins Is the criteria met?

  • Does the scope and size of the need justify providing access.
  • Is the individual a collaborator. If so then access should be allowed provided the first point is satisfied.
  • Length and consistency of involvement with Node.js working groups and/or community.
  • Consequences to the individual in case of misbehaviour. For example, would they potentially lose their job if they were reported as mis-behaving to their employer ? Would being banned from involvement in the Node.js community negatively affect them personally in some other way ?
  • Are there collaborators who work with the individual and can vouch for them.

From https://github.com/nodejs/build/blob/master/doc/process/special_access_to_build_resources.md

@sam-github
Copy link
Contributor

@victorgomes

@MylesBorins
Copy link
Member Author

  • Does the scope and size of the need justify providing access.

This is to unblock the landing of V8 7.8 for Node.js 13. The work should be completed in less than a week.

  • Is the individual a collaborator. If so then access should be allowed provided the first point is satisfied.

They Are not

  • Length and consistency of involvement with Node.js working groups and/or community.

They are a a member of the V8 team, who was requested to handle this problem after the TSC meeting we had yesterday

  • Consequences to the individual in case of misbehaviour. For example, would they potentially lose their job if they were reported as mis-behaving to their employer ? Would being banned from involvement in the Node.js community negatively affect them personally in some other way ?

They are an employee of Google. Misbehavior would be a risk to their employment.

  • Are there collaborators who work with the individual and can vouch for them.

I do

@sam-github
Copy link
Contributor

That's strong enough a case I would add access immediately, except I don't have any idea how to access the OS X CI machines, and can't find any docs on them in nodejs/build. ssh didn't work, but that's not a surprise.

@nodejs/platform-macos @nodejs/build Anyone have any ideas?

@mhdawson
Copy link
Member

@sam-github ssh should work, let me try.

@mhdawson
Copy link
Member

It works for our mac stadium 10.10 machines with this entry in the ssh config file

Host test-macstadium-macos10.10-x64-1
  HostName 207.254.58.162
  Port 10005
  IdentityFile ~/.ssh/nodejs_build_test
  User administrator

I've tried with test-requireio-osx1010-x64-1, which I think the config entry should be the following based on: https://github.com/nodejs/build/pull/1890/files.

Host test-requireio-osx1010-x64-1
  HostName 192.168.2.210
  IdentityFile ~/.ssh/nodejs_build_test
  User iojs
  ProxyCommand ssh -i ~/.ssh/nodejs_build_test -p 2222 jump@vagg-arm.nodejs.org nc -q0 %h %p

@rvagg I still can't connect with this entry, can you see what I've got wrong?

user1@user1-lbuntu:~/.ssh$ ssh test-requireio-osx1010-x64-1
ssh_exchange_identification: Connection closed by remote host

@mhdawson
Copy link
Member

@MylesBorins was test-requireio-osx1010-x64-1 chosen for a specific reason or would be ok ? test-macstadium-macos10.10-x64-1

@sam-github
Copy link
Contributor

Like @mhdawson, I can ssh into test-macstadium-macos10.10-x64-1, but not test-requireio-osx1010-x64-1:

ssh -vvv test-requireio-osx1010-x64-1
OpenSSH_7.9p1 Ubuntu-10, OpenSSL 1.1.1b  26 Feb 2019
debug1: Reading configuration data /home/sam/.ssh/config
debug1: /home/sam/.ssh/config line 17: Applying options for *
debug1: /home/sam/.ssh/config line 802: Applying options for test-requireio-osx1010-x64-1
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: /etc/ssh/ssh_config line 19: Applying options for *
debug2: resolve_canonicalize: hostname 192.168.2.210 is address
debug1: Executing proxy command: exec ssh -i ~/.ssh/ansible_ssh_private_key_file -p 2222 jump@vagg-arm.nodejs.org nc -q0 192.168.2.210 22
debug1: identity file /home/sam/.ssh/id_rsa type 0
debug1: identity file /home/sam/.ssh/id_rsa-cert type -1
debug1: identity file /home/sam/.ssh/nodejs_build_test type -1
debug1: identity file /home/sam/.ssh/nodejs_build_test-cert type -1
debug1: Local version string SSH-2.0-OpenSSH_7.9p1 Ubuntu-10
ssh_exchange_identification: Connection closed by remote host

@MylesBorins
Copy link
Member Author

MylesBorins commented Sep 19, 2019 via email

@sam-github
Copy link
Contributor

@victorgomes which of your keys would you like me to use? there are three at https://github.com/victorgomes.keys

@victorgomes
Copy link

@sam-github I will use the last ssh key (ending with oyUAw==).

@rvagg
Copy link
Member

rvagg commented Sep 20, 2019

Sorry, the requireio one is intentionally offline. Can be put back into service if needed but the macstadium ones seem to be going well for us.

@Trott
Copy link
Member

Trott commented Sep 20, 2019

Totally-unnecessary pile-on +1 from me.

@sam-github
Copy link
Contributor

@victorgomes use this config,with identity replaced with whatever yours is:

Host test-macstadium-macos10.10-x64-1 
  HostName 207.254.58.162
  IdentityFile ~/.ssh/nodejs_build_test
  User administrator
  Port 10005

Ping here when you are done and someone will remove your key (or you can remove the key then close this).

@victorgomes
Copy link

@sam-github Thanks. I will tell you when we're done.

@MylesBorins MylesBorins changed the title access for @victorgomes to test-requireio-osx1010-x64-1 access for @victorgomes to osx build bot Sep 23, 2019
@MylesBorins
Copy link
Member Author

@mhdawson which machine do we use to build 12.x? I'm guessing it isn't 10.10... should we have given access to one of the test-macstadium-macos10.12-2 machines?

@MylesBorins MylesBorins mentioned this issue Sep 23, 2019
Closed
@targos
Copy link
Member

targos commented Sep 23, 2019

@MylesBorins releases of 12.x are built with 10.11 machines.

@MylesBorins
Copy link
Member Author

ok great. @mhdawson can we get @victorgomes access to the 10.11 machines please?

@sam-github
Copy link
Contributor

@MylesBorins @victorgomes Added your key to test-macstadium-macos10.11-x64-1, removed it from test-macstadium-macos10.10-x64-1

Host test-macstadium-macos10.11-x64-1
  HostName 207.254.58.162
  IdentityFile ~/.ssh/nodejs_build_test
  User administrator
  Port 10003

@MylesBorins
Copy link
Member Author

We got a working build. Feel free to remove access and close issue

@sam-github
Copy link
Contributor

keys cleaned up, thanks @victorgomes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sam-github @rvagg @MylesBorins @victorgomes @Trott @targos @mhdawson