Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tap2junit from 0.1.4 to 0.1.5 #2092

Closed
Trott opened this issue Dec 14, 2019 · 4 comments
Closed

Update tap2junit from 0.1.4 to 0.1.5 #2092

Trott opened this issue Dec 14, 2019 · 4 comments

Comments

@Trott
Copy link
Member

Trott commented Dec 14, 2019

tap2junit 0.1.5 fixes bugs and introduces Python 3 compatibility. Can we please update?

Refs: nodejs/node#30955 (comment)
Maybe Refs: #1847
Maybe Refs: #1756
Maybe Refs: #1830

@Trott
Copy link
Member Author

Trott commented Dec 17, 2019

@sam-github

@sam-github
Copy link
Contributor

Work items (volunteers welcome, a number of the items below do not require build-wg membership):

  • Find out how tap2junit is installed: ... (ansible on most hosts)
  • Figure out if it is installed at a specific version: ... (probably its just latest at time of ansible run, but there might be a py3 and a py2 install, or possibly changes will be needed to install with both pip and pip3)
  • Modify ansible files: ... (if necessary, maybe they just need re-running)
  • List hosts that require update: ... (perhaps all test-* hosts, but we never bulk update every single host simultaneously, carnage is too likely)
  • Re-ansible the hosts: ... (some hosts have been ansibled more recently than others, so this can be a bit of a nail biter, the hosts have to be checked after to ensure they still function, and sometimes the ansbile scripts don't run anymore, and troubleshooting ensues)

@richardlau
Copy link
Member

richardlau commented Dec 17, 2019

Work items (volunteers welcome, a number of the items below do not require build-wg membership):

* [ ]  Find out how tap2junit is installed: ... (ansible on most hosts)

* [ ]  Figure out if it is installed at a specific version: ... (probably its just latest at time of ansible run, but there might be a py3 and a py2 install, or possibly changes will be needed to install with both pip and pip3)

* [ ]  Modify ansible files: ... (if necessary, maybe they just need re-running)

For ansible there are several files in https://github.com/nodejs/build/tree/master/ansible/roles/jenkins-worker/tasks/partials/tap2junit

None of the ansible files appear to specify a version of tap2junit to install.

@Trott
Copy link
Member Author

Trott commented Feb 8, 2020

I updated it manually, so I'm inclined to close this. Re-open if you think it should remain open.

@Trott Trott closed this as completed Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants