Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI jobs with --experimental-quic #2353

Closed
jasnell opened this issue Jun 16, 2020 · 7 comments
Closed

CI jobs with --experimental-quic #2353

jasnell opened this issue Jun 16, 2020 · 7 comments
Labels

Comments

@jasnell
Copy link
Member

jasnell commented Jun 16, 2020

The experimental QUIC support has landed in nodejs/node main branch. This is not built by default. It requires the use of the --experimental-quic configure flag to be enabled. It would be fantastic if we could have a set of jobs specific to QUIC on a subset of linux, mac, and windows machines that enable the --experimental-quic flag so that we can run CI on relevant PRs. (for Windows, the flag is vcbuild experimental-quic)

@jasnell
Copy link
Member Author

jasnell commented Jun 16, 2020

Note: none of the sharedlibs-openssl jobs should be included in the set of jobs using the --experimental-quic config.

@mmarchini
Copy link
Contributor

mmarchini commented Jun 17, 2020

https://ci.nodejs.org/job/node-test-commit/ with CONFIG_FLAG=--experimental-quic should work (well, for *nix jobs, I don't know about Windows). Would that be enough? Creating a new job (especially one that is not part of node-test-pull-request) can increase maintenance burden on the WG.

(edit: I see @richardlau already mentioned it on one both of the PRs :) )

@jasnell
Copy link
Member Author

jasnell commented Jun 17, 2020

It works, but since that includes the sharedlibs-openssl we won't ever get a completely green run since we cannot use quic with the shared openssl build

@rvagg
Copy link
Member

rvagg commented Jun 18, 2020

we cannot use quic with the shared openssl build

What's the hang-up on this? Is it the age of the openssl we have in sharedlibs? I haven't updated it in a while and could go ahead and do that to be more reasonably reflective of what people are likely using in the wild.

@richardlau
Copy link
Member

we cannot use quic with the shared openssl build

What's the hang-up on this? Is it the age of the openssl we have in sharedlibs? I haven't updated it in a while and could go ahead and do that to be more reasonably reflective of what people are likely using in the wild.

My understanding (nodejs/node#29817 (comment)) is that quic support in OpenSSL won't arrive until OpenSSL 3.0 at the earliest and for Node.js the embedded OpenSSL has been patched (nodejs/node#32377). So Node.js' quic support won't work with stock OpenSSL 1.1.1 (which is one of the reasons it's behind a non-default configure flag).

@rvagg
Copy link
Member

rvagg commented Jun 18, 2020

Ah, well if that's the case then maybe someone wants to hack together a bit of bash in https://ci.nodejs.org/view/All/job/node-test-commit-linux-containered/ (in the ubuntu1804_sharedlibs_openssl111_x64 job, I think that's all that's run for master) to exclude shared openssl when someone passes the --experimental-quic CONFIG_FLAGS. That'd at least help get to green.

@github-actions
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants