You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm adding benchmark tests to CI in nodejs/node#34288. The napi benchmark fails on Raspberry Pi because the result of the bench-addons-build task in Makefile needs to be available to the machine executing the test.
The text was updated successfully, but these errors were encountered:
The binary/binary.tar.xz gets added to a git pack and pushed to the shared git repo. Then on the Pi side it gets fetched from that repo and unpacked. So whatever's in it gets unpacked into a raw source checkout. We could just add more if [ -f ... blocks if you have other files to include and it'll always attempt to include those whenever a cross is run.
Looks like it just needed some Makefile changes that have happened. (@richardlau pointed out that the prerequisite build step and the test itself should have been added to the native suites job and not the JS suites job. WIth that change, everything seems to be working.) It's passing in CI now. Sorry for the noise.
I'm adding benchmark tests to CI in nodejs/node#34288. The napi benchmark fails on Raspberry Pi because the result of the
bench-addons-build
task in Makefile needs to be available to the machine executing the test.The text was updated successfully, but these errors were encountered: