Missing status label for GitHub check

[danielleadams]

When I opened a PR in nodejs/node (nodejs/node#36435), I started the node-test-pull-request job and one of the checks that I received is pictured in the following:

The Details link to: https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_debug_x64/23997/. The check says ${STATUS_LABEL} instead of the label that would have been received from Jenkins.

I'm not sure if this is a bug in GitHub or missing data that is updating the PR.

Update: Once the issue was resolved with the test, the status check is not getting marked as resolved/passed.

[richardlau]

I've shuffled around how the GitHub status labels are named in the node-test-commit-linux-containered job so that STATUS_LABEL is set as early as possible in the job. This should hopefully prevent edge cases were the job fails before STATUS_LABEL is set in future jobs.

[danielleadams]

thanks @richardlau!