Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI job request: daily coverage job without Intl #2596

Closed
Trott opened this issue Mar 27, 2021 · 8 comments
Closed

CI job request: daily coverage job without Intl #2596

Trott opened this issue Mar 27, 2021 · 8 comments

Comments

@Trott
Copy link
Member

Trott commented Mar 27, 2021

What do we all think about the idea of trying to set up a third test coverage job (to go along with the Linux one and the Windows one) to run Node.js compiled without Intl support? That would allow us to complete coverage in files like lib/internal/util/inspect.js.html. There's already a Jenkins job that does tests without Intl (https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutintl_x64/). I think we'd just need to modify it to do coverage, run nightly, and push results to the right place(s).

@mhdawson
Copy link
Member

I assume it would just contribute the coverage to https://app.codecov.io/gh/nodejs/node, right? If so then I don't see any issue and seems like a good idea.

@richardlau
Copy link
Member

As I understand the current status on this one, there's an in progress attempt to do this as a GitHub action: nodejs/node#37954

FWIW the Windows coverage job looks to have been broken for some time #2645

@github-actions
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label May 11, 2022
@Trott
Copy link
Member Author

Trott commented May 11, 2022

Still not ready to give up on this...

@github-actions github-actions bot removed the stale label May 12, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Mar 9, 2023
@targos
Copy link
Member

targos commented Mar 9, 2023

@Trott can we close now that nodejs/node#37954 has landed?

@github-actions github-actions bot removed the stale label Mar 10, 2023
@Trott
Copy link
Member Author

Trott commented Mar 12, 2023

@Trott can we close now that nodejs/node#37954 has landed?

If there's consensus to abandon our own coverage in coverage.nodejs.org and rely on codecov.,io, then yes. If not, then we probably want to get it added to coverage.nodejs.org. I'm fine if you close this.

Copy link

github-actions bot commented Jan 7, 2024

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Jan 7, 2024
@Trott Trott closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants