Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-test-commit-arm should use select-compiler.sh #2746

Closed
richardlau opened this issue Sep 3, 2021 · 1 comment · Fixed by #2753
Closed

node-test-commit-arm should use select-compiler.sh #2746

richardlau opened this issue Sep 3, 2021 · 1 comment · Fixed by #2753

Comments

@richardlau
Copy link
Member

While testing nodejs/node#38807 I noticed that we're using the default gcc/g++ binaries for the new arm64 containers.
e.g. https://ci.nodejs.org/job/node-test-commit-arm/38847/nodes=ubuntu1804-arm64/consoleFull

17:10:53 python3 ./configure --verbose 
17:10:56 Node.js configure: Found Python 3.6.9...
17:10:56 Detected C++ compiler (CXX=ccache g++) version: 7.5.0
17:10:56 WARNING: C++ compiler (CXX=ccache g++, 7.5.0) too old, need g++ 8.3.0 or clang++ 8.0.0
17:10:56 Detected C compiler (CC=ccache gcc) version: 7.5.0

We are installing the compilers into the containers, e.g.

g++-6 \
gcc-6 \
g++-8 \
gcc-8 \

but we're not using them. The job config currently hardcodes compiler selection: https://ci.nodejs.org/job/node-test-commit-arm/configure

  if [[ "$nodes" =~ centos[67]-(arm)?64-gcc8 ]]; then
    exec_cmd=". /opt/rh/devtoolset-8/enable; $exec_cmd"
  fi
  
  if [[ "$nodes" =~ centos[67]-(arm)?64-gcc6 ]]; then
    exec_cmd=". /opt/rh/devtoolset-6/enable; $exec_cmd"
  fi

i.e. currently only selects compilers for CentOS. I suggest we should use the select-compiler.sh script like we do elsewhere and extend for the Ubuntu containers. There are already arm64 entries for CentOS:

elif [ "$SELECT_ARCH" = "ARM64" ]; then
echo "Setting compiler for Node version $NODEJS_MAJOR_VERSION on arm64"
case $nodes in
centos7-arm64-gcc8 )
. /opt/rh/devtoolset-8/enable
echo "Compiler set to devtoolset-8"
;;
centos[67]-arm64-gcc6 )
. /opt/rh/devtoolset-6/enable
echo "Compiler set to devtoolset-6"
;;
esac
fi

@richardlau
Copy link
Member Author

richardlau commented Sep 8, 2021

I've changed https://ci.nodejs.org/job/node-test-commit-arm/ to use select-compiler.sh (audit trail: https://github.com/nodejs/jenkins-config-test/commit/36ae5de59baee59e23731f399f39777285f1b913).
Opened #2753 to add compiler selection for Ubuntu 18.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant